From: Greg KH <gregkh@linuxfoundation.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: stable@vger.kernel.org, Bailey Forrest <bcf@google.com>,
Eric Dumazet <edumazet@google.com>,
Jeroen de Borst <jeroendb@google.com>,
Kevin DeCabooter <decabooter@google.com>
Subject: Re: [PATCH 5.15 6.1] gve: Fix use-after-free vulnerability
Date: Fri, 2 Feb 2024 17:30:19 -0800 [thread overview]
Message-ID: <2024020210-navigate-oaf-b2be@gregkh> (raw)
In-Reply-To: <20240130214507.3391252-1-pkaligineedi@google.com>
On Tue, Jan 30, 2024 at 01:45:07PM -0800, Praveen Kaligineedi wrote:
> From: Bailey Forrest <bcf@google.com>
>
> Call skb_shinfo() after gve_prep_tso() on DQO TX path.
> gve_prep_tso() calls skb_cow_head(), which may reallocate
> shinfo causing a use after free.
>
> This bug was unintentionally fixed by 'a6fb8d5a8b69
> ("gve: Tx path for DQO-QPL")' while adding DQO-QPL format
> support in 6.6. That patch is not appropriate for stable releases.
>
> Fixes: a57e5de476be ("gve: DQO: Add TX path")
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Signed-off-by: Bailey Forrest <bcf@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Jeroen de Borst <jeroendb@google.com>
> Reviewed-by: Kevin DeCabooter <decabooter@google.com>
> ---
> drivers/net/ethernet/google/gve/gve_tx_dqo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-02-03 1:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 21:45 [PATCH 5.15 6.1] gve: Fix use-after-free vulnerability Praveen Kaligineedi
2024-02-03 1:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024020210-navigate-oaf-b2be@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcf@google.com \
--cc=decabooter@google.com \
--cc=edumazet@google.com \
--cc=jeroendb@google.com \
--cc=pkaligineedi@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox