From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E49E7482CA; Sat, 3 Feb 2024 04:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706933725; cv=none; b=WuNnwM9CG58RPFl/7GVHNZIa9kdZaRIhjQGUKNwPjcBkVLPXCi/ILn7EmzFYGc7onEzPv2/tjLIQLZjwWii9qivwAQulwg2R8Hkhs+NET3Lo1t7hqMI9D+x1IpeuRjJ3uVzPciw9H86EDbnq77yAGgubancKtANI/GN920GUNBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706933725; c=relaxed/simple; bh=fi0nMbBU0cYbEUtWNBjH35fdTaSJi0ZzS3EhdB5R6+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YzreB9W2g2lNZyhqsQI98UA72/TGy0Dlhj4W3DBRyrtPJwy99Ah+XWRcXqkRSIexGuLghQJ3JSAogTU3F37gHDmBVqXCnkj6ni0FHf5UwCmjEAH7zwvDWzlw/nAJv2U+Opmr0G36RPL9vfYgxRzrdjzQZFnobkHg/pcsKDYeXjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WGLV1yW+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WGLV1yW+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD05C43399; Sat, 3 Feb 2024 04:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706933724; bh=fi0nMbBU0cYbEUtWNBjH35fdTaSJi0ZzS3EhdB5R6+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WGLV1yW+NbR+Y1zbDkDq55CgW2hZl43aCWr2+PLTng5zhRnj+20OaM4i0W0b99jts eXukehTh0443s7f1XYRsMxFxjDdbSvZRGahFvVHainFmi3FnypCiq5AR0JqQfzDjLO sXwbZibt3FlIhViaTvujPI0z/XjtbyLJb2pKrIXs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christophe Leroy , Michael Ellerman , Kunwu Chan , Sasha Levin Subject: [PATCH 6.7 002/353] powerpc/mm: Fix null-pointer dereference in pgtable_cache_add Date: Fri, 2 Feb 2024 20:02:00 -0800 Message-ID: <20240203035403.742026617@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203035403.657508530@linuxfoundation.org> References: <20240203035403.657508530@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kunwu Chan [ Upstream commit f46c8a75263f97bda13c739ba1c90aced0d3b071 ] kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Suggested-by: Christophe Leroy Suggested-by: Michael Ellerman Signed-off-by: Kunwu Chan Signed-off-by: Michael Ellerman Link: https://msgid.link/20231204023223.2447523-1-chentao@kylinos.cn Signed-off-by: Sasha Levin --- arch/powerpc/mm/init-common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c index 119ef491f797..d3a7726ecf51 100644 --- a/arch/powerpc/mm/init-common.c +++ b/arch/powerpc/mm/init-common.c @@ -126,7 +126,7 @@ void pgtable_cache_add(unsigned int shift) * as to leave enough 0 bits in the address to contain it. */ unsigned long minalign = max(MAX_PGTABLE_INDEX_SIZE + 1, HUGEPD_SHIFT_MASK + 1); - struct kmem_cache *new; + struct kmem_cache *new = NULL; /* It would be nice if this was a BUILD_BUG_ON(), but at the * moment, gcc doesn't seem to recognize is_power_of_2 as a @@ -139,7 +139,8 @@ void pgtable_cache_add(unsigned int shift) align = max_t(unsigned long, align, minalign); name = kasprintf(GFP_KERNEL, "pgtable-2^%d", shift); - new = kmem_cache_create(name, table_size, align, 0, ctor(shift)); + if (name) + new = kmem_cache_create(name, table_size, align, 0, ctor(shift)); if (!new) panic("Could not allocate pgtable cache for order %d", shift); -- 2.43.0