From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65E261CAAD; Sat, 3 Feb 2024 04:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706933879; cv=none; b=XxAVFckqmPVvB/e6YZNHu2nbSmw0Vm4gAGQKT5UFRPJdvejvPBXqPQbxLpQjJbgFAS2+vIRZIz4DCVrzGj19t4TKy+FcJ+Fkw+R6uZc5oFfLCI7hOBkgvL+XPR0OwkXcnqY7HW8ELPA6knOUOOlm12eYjwHvdPqjhuRpOgmeK+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706933879; c=relaxed/simple; bh=JpjuQnrhCeVltkB8FUPpHEpV2GDcN6ztc9uZjo41Qwk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FVxjOXBuPJbTGw1hM702b9qaiiu3bwygyqrBH7PQHaeQ6xOc6TT5MnNYDjwsUvLbcQB4vvfoSd2MspuXrTn4zCwJLJvtk305q4eTfQ8hgHe7ditawq0EoJ7IQtEdiGSAd3jFCS16mgcgfCQJVdGiCGhXEFb6wYmOZWGCWxbPyAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Q7sgqRQK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Q7sgqRQK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B6CBC43390; Sat, 3 Feb 2024 04:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1706933879; bh=JpjuQnrhCeVltkB8FUPpHEpV2GDcN6ztc9uZjo41Qwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q7sgqRQKdA0hS+BPTjGf3mVWSRfbNlxDmAFODmB9L5LRP3blFj/OYDY9TMjwW9Wio viHAMMdt2kVOYLiA9t0uyTEcFHcaaTMfqPffMDAYSgvD5rstgVcbMK8zh0ZSNu1xjq //bup4SWj2ITXjkoj7JAFYP7KnfcvuXbcag2KTkA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dafna Hirschfeld , Oded Gabbay , Sasha Levin Subject: [PATCH 6.7 219/353] accel/habanalabs/gaudi2: fix undef opcode reporting Date: Fri, 2 Feb 2024 20:05:37 -0800 Message-ID: <20240203035410.612317951@linuxfoundation.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203035403.657508530@linuxfoundation.org> References: <20240203035403.657508530@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dafna Hirschfeld [ Upstream commit 0ec346779644039c4c05cfa7f071b1a24e54d8d9 ] currently the undefined opcode event bit in set only for lower cp and only if 'write_enable' is true. It should be set anyway and for all streams in order to report that event to userspace. Signed-off-by: Dafna Hirschfeld Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay Signed-off-by: Sasha Levin --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c index 819660c684cf..bc6e338ef2fd 100644 --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c @@ -7929,21 +7929,19 @@ static int gaudi2_handle_qman_err_generic(struct hl_device *hdev, u16 event_type error_count++; } - if (i == QMAN_STREAMS && error_count) { - /* check for undefined opcode */ - if (glbl_sts_val & PDMA0_QM_GLBL_ERR_STS_CP_UNDEF_CMD_ERR_MASK && - hdev->captured_err_info.undef_opcode.write_enable) { + /* check for undefined opcode */ + if (glbl_sts_val & PDMA0_QM_GLBL_ERR_STS_CP_UNDEF_CMD_ERR_MASK) { + *event_mask |= HL_NOTIFIER_EVENT_UNDEFINED_OPCODE; + if (hdev->captured_err_info.undef_opcode.write_enable) { memset(&hdev->captured_err_info.undef_opcode, 0, sizeof(hdev->captured_err_info.undef_opcode)); - - hdev->captured_err_info.undef_opcode.write_enable = false; hdev->captured_err_info.undef_opcode.timestamp = ktime_get(); hdev->captured_err_info.undef_opcode.engine_id = gaudi2_queue_id_to_engine_id[qid_base]; - *event_mask |= HL_NOTIFIER_EVENT_UNDEFINED_OPCODE; } - handle_lower_qman_data_on_err(hdev, qman_base, *event_mask); + if (i == QMAN_STREAMS) + handle_lower_qman_data_on_err(hdev, qman_base, *event_mask); } } -- 2.43.0