Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: stable <stable@vger.kernel.org>, Sean Christopherson <seanjc@google.com>
Subject: Re: Please put the gcc "asm goto" bug workaround into stable
Date: Fri, 16 Feb 2024 19:45:13 +0100	[thread overview]
Message-ID: <2024021623-puma-sympathy-1a4a@gregkh> (raw)
In-Reply-To: <CAHk-=wgcbbNw-dJu_=9xT3KR-xRgPYG7yLeUwqLkCKoRamx5Ug@mail.gmail.com>

On Fri, Feb 16, 2024 at 07:57:01AM -0800, Linus Torvalds wrote:
> I didn't think to mark these for stable in the commits, but they
> definitely should go into the stable queue, since it's a known
> mis-compilation of the kvm nested guest code with gcc-11 otherwise.
> 
> The bug technically affects other gcc versions too, but apparently not
> so that we'd actually notice.
> 
> It's two commits:
> 
>   4356e9f841f7 ("work around gcc bugs with 'asm goto' with outputs")
>   68fb3ca0e408 ("update workarounds for gcc "asm goto" issue")
> 
> where the first one works around the problem, and the second one
> ("update") just ends up pinpointing exactly which gcc versions are
> affected so that future gcc releases won't get the unnecessary
> workaround.
> 
> Technically only the first one really needs to go into stable. The
> second one is more of a judgement call - do you want to match
> upstream, and do you care about the (very slight) code generation
> improvement with updated gcc versions?

I've queued both up for 6.6.y and 6.7.y and they took a bit of
hand-holding to get merged.  I gave up at 6.1.y and if anyone wants them
there, I'll gladly take a working backport, but I'm not going to attempt
it.

thanks,

greg k-h

  reply	other threads:[~2024-02-16 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 15:57 Please put the gcc "asm goto" bug workaround into stable Linus Torvalds
2024-02-16 18:45 ` Greg Kroah-Hartman [this message]
2024-02-16 19:14   ` Linus Torvalds
2024-02-17 13:32     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024021623-puma-sympathy-1a4a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox