From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FD65C5FC for ; Tue, 20 Feb 2024 08:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708416740; cv=none; b=H/BfLo/Eoth3I8YNFMKpcsV8t2GwPLa0mJi/LMtw0nY0bkdrnunECi/wavYWTgXkEShK4T72yDZOuGm5PT1STyqmN0BzvZ9y75LaHvyuV7TNX7we5hSthLa0dU5niUQv1X7e/QnRUFgfPvYGEvB16V8Ob3BPGwC1mXbxQt5mjTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708416740; c=relaxed/simple; bh=/rabM4Ojv3qXPABWhPOzcXvWzcE1bpcBe1707Z9xKgg=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=oU0tqU48HU44NSDICQfn+xo9PG22Au1FpcltsBgwpbe1THFij9oW2jKTQuYGZSWMSzRWjDTnLDWk2Wwe8YSCp478dIqYuirmq0ZQQfYWX3HUab02231yjeszQcZPwQBncocVexBaSgTt4fY+X+35IhWSJ+040CkOr8L3lWCdoX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--raychi.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=g+nggSxm; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--raychi.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g+nggSxm" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc6b26eef6cso7509696276.3 for ; Tue, 20 Feb 2024 00:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708416736; x=1709021536; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=7NyTQc14Zf/h2SqeLHUekdRb34OTt1i2UvuEmj+OuFE=; b=g+nggSxmQkbCXvjQQMjfd+GJrhqjetnwR3vH3J7tBDV3Mki9t9r4v1QDZnCPz5OK88 kG6dQSYSd73EVxG6bae7vMB7ZAP+fbZanubSs/NaF8qvgLPygjoSgLLS+ZUhO+TC3zy6 lvYQcIoD1oYrhwiyo6s2bNb9OQ8/J7BgLzwxBN/iFSoax/63sS82m6waRJSSYe26oOp0 c6DlUqQYAQEllT78ObvQYJg7nN5+WCor/I4P62AVuztaruIblbXmezvm6tTFkJlwmnzL DKyZW8x2J1vf+gOCdsx8h7krEexg/qz7i0R7bc9C29X9FUOcw8j4Qzg6iR+kmJ0iYi3x JpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708416736; x=1709021536; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7NyTQc14Zf/h2SqeLHUekdRb34OTt1i2UvuEmj+OuFE=; b=MMjI8ArSksIYHjqDf7ChTkDPE0A0AzFOnZ0F/mju1fRuLyqNSmS4IPi8tIhenTbTEU y/hEnODy2CWEFBdOD0D6ogeeUtbnLO2iF1OlEf2UKq4Q/at5ARUlxmzIEBmv8DprN8wW qCNUqOoAzKhyhtjwacpIUS+gKlV2v++jcTIF+CN3iFE1iola+E2kJGD6O9TlytPnnE/7 lNUzAmbkcUmp365PHzmZhe05vp95nyfw742xOdcIWhITz0HAnNqdI73eHdke/JaYqENO iiVSLyjAyyPidEcgT5HZcGp+XkFFfpHMFmYkPP8QhR0uFTs1lKFAEVUm6W0t8HkY8z1L xVBA== X-Forwarded-Encrypted: i=1; AJvYcCV1mTeR0KrDzAnIzukjWwpWcZv5p2yvT3C68piEoeHKXgwlaj22ZIgE+Uxf32kK5fIOXqV4L5xs62Ypw4+zCP7F/9g3ij81 X-Gm-Message-State: AOJu0Yz86wdC63tV3APucmYobQkz7O2/A1/F3t1rbwHOonUYXPL3ZJvp X1A03Af+BFoscF940mxOyXeEUAnYUNwRaTj9ai2gjArNtBFGS74AY35UeobYDMdPaRxZk7HbTGc 1Yg== X-Google-Smtp-Source: AGHT+IHNQS6LSHevRMTxDokV0cAYaI5EkrQn4V1Y4tZL0I+ejqlFuzOyBy3AA2eQbWjAGfgyiPZewI6v+oY= X-Received: from raychi-p620lin01.ntc.corp.google.com ([2401:fa00:fc:202:d899:e5b8:ba5f:3c9]) (user=raychi job=sendgmr) by 2002:a25:abec:0:b0:dcc:94b7:a7a3 with SMTP id v99-20020a25abec000000b00dcc94b7a7a3mr495450ybi.12.1708416736722; Tue, 20 Feb 2024 00:12:16 -0800 (PST) Date: Tue, 20 Feb 2024 16:12:04 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Message-ID: <20240220081205.135063-1-raychi@google.com> Subject: [PATCH] usb: dwc3: gadget: remove warning during kernel boot From: Ray Chi To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org, quic_uaggarwa@quicinc.com Cc: albertccwang@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ray Chi , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" The dwc3->gadget_driver is not initialized during the dwc3 probe process. This leads to a warning when the runtime power management (PM) attempts to suspend the gadget using dwc3_gadget_suspend(). This patch adds a check to prevent the warning. Cc: stable@vger.kernel.org Fixes: 61a348857e86 ("usb: dwc3: gadget: Fix NULL pointer dereference in dwc3_gadget_suspend") Signed-off-by: Ray Chi --- drivers/usb/dwc3/gadget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 28f49400f3e8..de987cffe1ec 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4708,6 +4708,9 @@ int dwc3_gadget_suspend(struct dwc3 *dwc) unsigned long flags; int ret; + if (!dwc->gadget_driver) + return 0; + ret = dwc3_gadget_soft_disconnect(dwc); if (ret) goto err; -- 2.44.0.rc0.258.g7320e95886-goog