From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544E06A8D5 for ; Tue, 20 Feb 2024 20:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708460345; cv=none; b=fIPaApmMZfJopS4zuycjfPU91U8Pbz+pqPMrK88mRbX9Bfr9oqjc3XaUHD/61LtpTygjmlS2qHaiLoLqwuJRcb9Y/0T0wcvy7wBUKt+FpoNaoPdwzADI8fPQoOLbKc3otcxlasr60vg5/Vd4ZR4dWxVlM7N5FUh3q2+fQeh5fFg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708460345; c=relaxed/simple; bh=FAaynrohpdas5rzWEVPWb1tqCCjcFWIVJk4+A2BbzlE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ll4yYXbzOynArW2STqoxuk0rYwodwJEQJffpgDIyMY9PNgqXYfYoQ4+DSo+cJY1nRO3J10dPqsBkrGPV3GbjnAv5mmgl1aKAzoNEjTj5R1qFg0nKnXGw7b+k4p5zCGOjSjG3JCKAkA3yi7WHJIcezkSuC+Umogg8+cL2xVQvUhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2uLy4Du9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2uLy4Du9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E570C433C7; Tue, 20 Feb 2024 20:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708460344; bh=FAaynrohpdas5rzWEVPWb1tqCCjcFWIVJk4+A2BbzlE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2uLy4Du9kekcuOxUi7NF0Q7M3C+jO5vipBdXuByS3k6QRZSfhK5/sJmDP/FByEO2M 1bgumv/c/pJq4zsNmRolRLpiBYCYOduy/Rn//fWiW/oJeOS5q/vS7QTZkgpy0EPgxq 3sF9bZ+8OW+CItDMkiOZUox7vKb33OHVj0oEAm44= Date: Tue, 20 Feb 2024 21:19:01 +0100 From: Greg KH To: Kent Overstreet Cc: Sasha Levin , stable@vger.kernel.org Subject: Re: fs/bcachefs/ Message-ID: <2024022022-viewless-astronaut-ab8c@gregkh> References: <2024022056-monkhood-fossil-ec02@gregkh> <2024022007-buggy-operator-2dc5@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 20, 2024 at 03:06:14PM -0500, Kent Overstreet wrote: > On Tue, Feb 20, 2024 at 07:53:04PM +0100, Greg KH wrote: > > On Tue, Feb 20, 2024 at 07:03:23PM +0100, Greg KH wrote: > > > On Tue, Feb 20, 2024 at 12:23:33PM -0500, Kent Overstreet wrote: > > > > On Mon, Jan 15, 2024 at 06:03:11PM -0500, Sasha Levin wrote: > > > > > On Mon, Jan 15, 2024 at 05:12:17PM -0500, Kent Overstreet wrote: > > > > > > Hi stable team - please don't take patches for fs/bcachefs/ except from > > > > > > myself; I'll be doing backports and sending pull requests after stuff > > > > > > has been tested by my CI. > > > > > > > > > > > > Thanks, and let me know if there's any other workflow things I should > > > > > > know about > > > > > > > > > > Sure, we can ignore fs/bcachefs/ patches. > > > > > > > > I see that you even acked this. > > > > > > > > What the fuck? > > > > > > Accidents happen, you were copied on those patches. I'll go drop them > > > now, not a big deal. > > > > Wait, why are you doing "Fixes:" with an empty tag in your commits like > > 1a1c93e7f814 ("bcachefs: Fix missing bch2_err_class() calls")? > > > > That's messing with scripts and doesn't make much sense. Please put a > > real git id in there as the documentation suggests to. > > There isn't always a clear-cut commit when a regression was introduced > (it might not have been a regresison at all). I could dig and make > something up, but that's slowing down your workflow, and I thought I was > going to be handling all the stable backports for fs/bcachefs/, so - ? > Doesn't matter, please do not put "fake" tags in commit messages like this. It hurts all of the people that parse commit logs. Just don't put a fixes tag at all as the documentation states that after "Fixes:" a commit id belongs. thanks, greg k-h