Re: [PATCH 6.1 174/197] wifi: mwifiex: Support SD8978 chipset

Francesco Dolcini
2024-02-21T08:39:10Z

On Wed, Feb 21, 2024 at 09:12:23AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 21, 2024 at 09:03:53AM +0100, Francesco Dolcini wrote:
> > On Tue, Feb 20, 2024 at 09:52:13PM +0100, Greg Kroah-Hartman wrote:
> > > 6.1-stable review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Lukas Wunner <lukas@wunner.de>
> > >
> > > [ Upstream commit bba047f15851c8b053221f1b276eb7682d59f755 ]
> > >
> > > The Marvell SD8978 (aka NXP IW416) uses identical registers as SD8987,
> > > so reuse the existing mwifiex_reg_sd8987 definition.
> > >
> > > Note that mwifiex_reg_sd8977 and mwifiex_reg_sd8997 are likewise
> > > identical, save for the fw_dump_ctrl register: They define it as 0xf0
> > > whereas mwifiex_reg_sd8987 defines it as 0xf9. I've verified that
> > > 0xf9 is the correct value on SD8978. NXP's out-of-tree driver uses
> > > 0xf9 for all of them, so there's a chance that 0xf0 is not correct
> > > in the mwifiex_reg_sd8977 and mwifiex_reg_sd8997 definitions. I cannot
> > > test that for lack of hardware, hence am leaving it as is.
> > >
> > > NXP has only released a firmware which runs Bluetooth over UART.
> > > Perhaps Bluetooth over SDIO is unsupported by this chipset.
> > > Consequently, only an "sdiouart" firmware image is referenced, not an
> > > alternative "sdsd" image.
> > >
> > > Signed-off-by: Lukas Wunner <lukas@wunner.de>
> > > Signed-off-by: Kalle Valo <kvalo@kernel.org>
> > > Link: https://lore.kernel.org/r/536b4f17a72ca460ad1b07045757043fb0778988.1674827105.git.lukas@wunner.de
> > > Stable-dep-of: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> >
> > I would drop this and 1c5d463c0770.
>
> Why? Commit 1c5d463c0770 was explicitly tagged for stable inclusion,
> what changed?

1c5d463c0770 is a fix for bba047f15851c8b053221f1b276eb7682d59f755.

So there is no bug, unless bba047f15851c8b053221f1b276eb7682d59f755 is
there.

The mistake that we did at that time is that it should have been

Cc: stable@vger.kernel.org
Fixes: bba047f15851 ("wifi: mwifiex: Support SD8978 chipset")

Sorry about that.

Francesco