From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Philip Müller" <philm@manjaro.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
'Roman Gilg' <romangg@manjaro.org>, Mark Wagie <mark@manjaro.org>
Subject: Re: [Regression] 5.4.269 fails to build due to security/apparmor/af_unix.c:583:17: error: too few arguments to function ‘unix_state_lock_nested’
Date: Sat, 24 Feb 2024 10:11:18 +0100 [thread overview]
Message-ID: <2024022453-showcase-antonym-f49b@gregkh> (raw)
In-Reply-To: <0ca1f9f0-6a09-4beb-bbdb-101b3fc19c45@manjaro.org>
On Fri, Feb 23, 2024 at 11:18:40PM +0700, Philip Müller wrote:
> Hi Greg,
>
> the issue might be due to this patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/releases/5.4.269/af_unix-fix-lockdep-positive-in-sk_diag_dump_icons.patch
>
> 2024-02-23T15:39:05.6297767Z CC kernel/sys_ni.o
> 2024-02-23T15:39:05.7583048Z security/apparmor/af_unix.c: In function
> ‘unix_state_double_lock’:
> 2024-02-23T15:39:05.7586076Z security/apparmor/af_unix.c:583:17: error: too
> few arguments to function ‘unix_state_lock_nested’
> 2024-02-23T15:39:05.7588374Z 583 | unix_state_lock_nested(sk2);
> 2024-02-23T15:39:05.7589913Z | ^~~~~~~~~~~~~~~~~~~~~~
> 2024-02-23T15:39:05.7591564Z In file included from
> security/apparmor/include/af_unix.h:15,
> 2024-02-23T15:39:05.7593341Z from
> security/apparmor/af_unix.c:17:
> 2024-02-23T15:39:05.7594989Z ./include/net/af_unix.h:77:20: note: declared
> here
> 2024-02-23T15:39:05.7596733Z 77 | static inline void
> unix_state_lock_nested(struct sock *sk,
> 2024-02-23T15:39:05.7598516Z | ^~~~~~~~~~~~~~~~~~~~~~
> 2024-02-23T15:39:05.7600862Z security/apparmor/af_unix.c:586:17: error: too
> few arguments to function ‘unix_state_lock_nested’
> 2024-02-23T15:39:05.7603177Z 586 | unix_state_lock_nested(sk1);
> 2024-02-23T15:39:05.7605189Z | ^~~~~~~~~~~~~~~~~~~~~~
> 2024-02-23T15:39:05.7606765Z ./include/net/af_unix.h:77:20: note: declared
> here
> 2024-02-23T15:39:05.7608497Z 77 | static inline void
> unix_state_lock_nested(struct sock *sk,
> 2024-02-23T15:39:05.7610208Z | ^~~~~~~~~~~~~~~~~~~~~~
> 2024-02-23T15:39:05.8002385Z make[2]: *** [scripts/Makefile.build:262:
> security/apparmor/af_unix.o] Error 1
> 2024-02-23T15:39:05.8005077Z make[2]: *** Waiting for unfinished jobs....
> 2024-02-23T15:39:05.8094726Z CC crypto/scatterwalk.o
> 2024-02-23T15:39:05.9082621Z CC [M] fs/btrfs/sysfs.o
> 2024-02-23T15:39:06.2502316Z CC kernel/nsproxy.o
> 2024-02-23T15:39:06.4094246Z make[1]: *** [scripts/Makefile.build:497:
> security/apparmor] Error 2
> 2024-02-23T15:39:06.4207119Z make: *** [Makefile:1750: security] Error 2
> 2024-02-23T15:39:06.4208636Z CC kernel/notifier.o
> 2024-02-23T15:39:06.4210296Z make: *** Waiting for unfinished jobs....
> 2024-02-23T15:39:06.8604827Z CC crypto/proc.o
Odd line wrapping :(
Anyway, what config options are you using? I can't see this here and
none of the CI systems caught it either.
thanks,
greg k-h
next prev parent reply other threads:[~2024-02-24 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 16:18 [Regression] 5.4.269 fails to build due to security/apparmor/af_unix.c:583:17: error: too few arguments to function ‘unix_state_lock_nested’ Philip Müller
2024-02-24 9:11 ` Greg Kroah-Hartman [this message]
2024-02-26 4:28 ` Philip Müller
2024-02-26 4:31 ` Philip Müller
2024-02-27 9:02 ` Greg Kroah-Hartman
2024-02-27 9:11 ` Greg Kroah-Hartman
2024-02-26 15:05 ` Philip Müller
2024-02-26 19:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024022453-showcase-antonym-f49b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=mark@manjaro.org \
--cc=philm@manjaro.org \
--cc=romangg@manjaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox