* Re: [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing [not found] <20240224052436.3552333-1-saravanak@google.com> @ 2024-02-24 5:28 ` Saravana Kannan 2024-02-26 12:04 ` Luca Ceresoli 2024-02-29 0:20 ` Rob Herring 0 siblings, 2 replies; 3+ messages in thread From: Saravana Kannan @ 2024-02-24 5:28 UTC (permalink / raw) To: Rob Herring, Frank Rowand, Saravana Kannan Cc: Hervé Codina, Luca Ceresoli, kernel-team, Rob Herring, devicetree, linux-kernel, Greg Kroah-Hartman, stable On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan <saravanak@google.com> wrote: > > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > finding the supplier of a remote-endpoint property") due to a last minute > incorrect edit of "index !=0" into "!index". This patch fixes it to be > "index > 0" to match the comment right next to it. Greg, this needs to land in the stable branches once Rob picks it up for the next 6.8-rc. -Saravana > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > Signed-off-by: Saravana Kannan <saravanak@google.com> > --- > Using Link: instead of Closes: because Luca reported two separate issues. > > Sorry about introducing a stupid bug in an -rcX Rob. > > -Saravana > > drivers/of/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index b71267c6667c..fa8cd33be131 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np, > int index) > { > /* Return NULL for index > 0 to signify end of remote-endpoints. */ > - if (!index || strcmp(prop_name, "remote-endpoint")) > + if (index > 0 || strcmp(prop_name, "remote-endpoint")) > return NULL; > > return of_graph_get_remote_port_parent(np); > -- > 2.44.0.rc0.258.g7320e95886-goog > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing 2024-02-24 5:28 ` [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing Saravana Kannan @ 2024-02-26 12:04 ` Luca Ceresoli 2024-02-29 0:20 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Luca Ceresoli @ 2024-02-26 12:04 UTC (permalink / raw) To: Saravana Kannan, Greg Kroah-Hartman Cc: Rob Herring, Frank Rowand, Hervé Codina, kernel-team, Rob Herring, devicetree, linux-kernel, stable Hello Greg, Saravana, On Fri, 23 Feb 2024 21:28:18 -0800 Saravana Kannan <saravanak@google.com> wrote: > On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan <saravanak@google.com> wrote: > > > > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > > finding the supplier of a remote-endpoint property") due to a last minute > > incorrect edit of "index !=0" into "!index". This patch fixes it to be > > "index > 0" to match the comment right next to it. > > Greg, this needs to land in the stable branches once Rob picks it up > for the next 6.8-rc. > > -Saravana > > > > > Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com> > > Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ > > Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") > > Signed-off-by: Saravana Kannan <saravanak@google.com> > > --- > > Using Link: instead of Closes: because Luca reported two separate issues. As Saravana mentioned, this fixes only one bug in the original commit. Unless there is a quick solution for the other bug, we are still left with a regression since that got merged in 6.8-rc5. So I propose to revert 782bfd03c3ae instead of applying this one, to leave the needed time for a correct solution to be deviesd. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing 2024-02-24 5:28 ` [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing Saravana Kannan 2024-02-26 12:04 ` Luca Ceresoli @ 2024-02-29 0:20 ` Rob Herring 1 sibling, 0 replies; 3+ messages in thread From: Rob Herring @ 2024-02-29 0:20 UTC (permalink / raw) To: Saravana Kannan Cc: Frank Rowand, Hervé Codina, Luca Ceresoli, kernel-team, devicetree, linux-kernel, Greg Kroah-Hartman, stable On Fri, Feb 23, 2024 at 11:29 PM Saravana Kannan <saravanak@google.com> wrote: > > On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan <saravanak@google.com> wrote: > > > > Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve > > finding the supplier of a remote-endpoint property") due to a last minute > > incorrect edit of "index !=0" into "!index". This patch fixes it to be > > "index > 0" to match the comment right next to it. > > Greg, this needs to land in the stable branches once Rob picks it up > for the next 6.8-rc. Uh, what? Only if I ignore this patch until 6.8 is released. Otherwise, the bug and fix are both landing in 6.8. Rob ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-29 0:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240224052436.3552333-1-saravanak@google.com>
2024-02-24 5:28 ` [PATCH] of: property: fw_devlink: Fix stupid bug in remote-endpoint parsing Saravana Kannan
2024-02-26 12:04 ` Luca Ceresoli
2024-02-29 0:20 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).