From: Christian Brauner <brauner@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>, Jens Axboe <axboe@kernel.dk>
Cc: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Avi Kivity <avi@scylladb.com>,
Sandeep Dhavale <dhavale@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
stable@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: (subset) [PATCH v4 2/2] fs/aio: Make io_cancel() generate completions again
Date: Tue, 27 Feb 2024 09:55:49 +0100 [thread overview]
Message-ID: <20240227-kostenlos-handwagen-e8dbe564375c@brauner> (raw)
In-Reply-To: <20240215204739.2677806-3-bvanassche@acm.org>
On Thu, 15 Feb 2024 12:47:39 -0800, Bart Van Assche wrote:
> The following patch accidentally removed the code for delivering
> completions for cancelled reads and writes to user space: "[PATCH 04/33]
> aio: remove retry-based AIO"
> (https://lore.kernel.org/all/1363883754-27966-5-git-send-email-koverstreet@google.com/)
> >From that patch:
>
> - if (kiocbIsCancelled(iocb)) {
> - ret = -EINTR;
> - aio_complete(iocb, ret, 0);
> - /* must not access the iocb after this */
> - goto out;
> - }
>
> [...]
@Jens, please take another look at this.
---
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[2/2] fs/aio: Make io_cancel() generate completions again
https://git.kernel.org/vfs/vfs/c/ff365e6bc31c
prev parent reply other threads:[~2024-02-27 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240215204739.2677806-1-bvanassche@acm.org>
2024-02-15 20:47 ` [PATCH v4 1/2] fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio Bart Van Assche
2024-02-21 14:26 ` Jens Axboe
2024-02-21 15:32 ` (subset) " Christian Brauner
2024-03-04 19:10 ` Eric Biggers
2024-03-04 19:43 ` Bart Van Assche
2024-03-04 20:21 ` Jens Axboe
2024-03-05 20:43 ` Bart Van Assche
2024-03-05 21:55 ` Jens Axboe
2024-03-04 20:09 ` Jens Axboe
2024-03-04 20:49 ` Eric Biggers
2024-03-04 20:53 ` Jens Axboe
2024-02-15 20:47 ` [PATCH v4 2/2] fs/aio: Make io_cancel() generate completions again Bart Van Assche
2024-02-16 7:13 ` Christoph Hellwig
2024-02-16 12:08 ` Christian Brauner
2024-02-16 17:11 ` Bart Van Assche
2024-02-27 8:55 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227-kostenlos-handwagen-e8dbe564375c@brauner \
--to=brauner@kernel.org \
--cc=avi@scylladb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dhavale@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kent.overstreet@linux.dev \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox