From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02FD71448F1; Tue, 27 Feb 2024 13:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709041554; cv=none; b=NyKJOYpKo45aenCIU/HKJxFv9kE/JdZCQJcXPQ1MGvwUCbvJE5eRLi6u0OP7kGvuunisSsmcgvaYjSIJhH9BvN+c/bQsAm9DSPkiVg/OBQ50+kzkMS6rUFaBqgyN2c0qAm1nDynclyAk24hLEa1l1CMMqE34G8Lbbf9GhIAQ6kI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709041554; c=relaxed/simple; bh=pabyUPGumAtK5LkNQfxRny6vvotcj6hyWS+DXAC7Lvk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aQsbRy5b7aN8niuGIQppozfqwejhqC+BdZcrZcy5yTN7SsGTCMl1VRTnnTLOav/XJjuoi3pN3qLY08GnXX7vFk1dMNrdjSrKal1kZOD56pKQXP+CvEXHJl+qnolwfRG8zIknMcXp9Aum8VPxJGtdkmLzVoFz1ZT/mvb6IGy+QzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L8h10WEt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L8h10WEt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87BB1C433C7; Tue, 27 Feb 2024 13:45:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709041553; bh=pabyUPGumAtK5LkNQfxRny6vvotcj6hyWS+DXAC7Lvk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L8h10WEtX7YfI5qUvLT7OCsedCRajAX74u786zYxbatviGsWSqoj6II2BeGgwoucM d0K2wkUlvW90JbdPn/IdnpdiUpEbga2rOVzUGS850vQn55G7GaPS5Afhgrf5Xh4oj8 0F+wtOpu8g4io/a4fEBcx1IaQrmeH7xt7kpkaZKc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Vasiliy Kovalev , Paolo Abeni , Sasha Levin Subject: [PATCH 4.19 45/52] ipv6: sr: fix possible use-after-free and null-ptr-deref Date: Tue, 27 Feb 2024 14:26:32 +0100 Message-ID: <20240227131550.015311375@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131548.514622258@linuxfoundation.org> References: <20240227131548.514622258@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vasiliy Kovalev [ Upstream commit 5559cea2d5aa3018a5f00dd2aca3427ba09b386b ] The pernet operations structure for the subsystem must be registered before registering the generic netlink family. Fixes: 915d7e5e5930 ("ipv6: sr: add code base for control plane support of SR-IPv6") Signed-off-by: Vasiliy Kovalev Link: https://lore.kernel.org/r/20240215202717.29815-1-kovalev@altlinux.org Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/ipv6/seg6.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/net/ipv6/seg6.c b/net/ipv6/seg6.c index 89d55770ac74b..4bd601c964343 100644 --- a/net/ipv6/seg6.c +++ b/net/ipv6/seg6.c @@ -445,22 +445,24 @@ int __init seg6_init(void) { int err = -ENOMEM; - err = genl_register_family(&seg6_genl_family); + err = register_pernet_subsys(&ip6_segments_ops); if (err) goto out; - err = register_pernet_subsys(&ip6_segments_ops); + err = genl_register_family(&seg6_genl_family); if (err) - goto out_unregister_genl; + goto out_unregister_pernet; #ifdef CONFIG_IPV6_SEG6_LWTUNNEL err = seg6_iptunnel_init(); if (err) - goto out_unregister_pernet; + goto out_unregister_genl; err = seg6_local_init(); - if (err) - goto out_unregister_pernet; + if (err) { + seg6_iptunnel_exit(); + goto out_unregister_genl; + } #endif #ifdef CONFIG_IPV6_SEG6_HMAC @@ -481,11 +483,11 @@ int __init seg6_init(void) #endif #endif #ifdef CONFIG_IPV6_SEG6_LWTUNNEL -out_unregister_pernet: - unregister_pernet_subsys(&ip6_segments_ops); -#endif out_unregister_genl: genl_unregister_family(&seg6_genl_family); +#endif +out_unregister_pernet: + unregister_pernet_subsys(&ip6_segments_ops); goto out; } -- 2.43.0