From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EB0713B2B8; Tue, 27 Feb 2024 14:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043870; cv=none; b=Fx39YMQsOT1zbk3c4yce2RtVei8kgw7Gz1i13UNuun39Rz+RgDbFPZL3oJh2jwiNoCefqUA/aUcZ5L+bFud+1AVfPhHAXJOiwxVjo1sz3mpv3D2JJWuUV9iSUeDhbbso8dLHxVOKSRSsCl0hQ39H83P3WcuXS0YWYdAnaCZbYNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043870; c=relaxed/simple; bh=urVwESKAPbYwzk9lRkDNB4g5/1VzRr+r/46DLK5795Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qZNmVLNrTBC2E42kHKQzIndfic+hH3LSlyBa0sh/u0wB3AyBk1cPXd96uw8l/UGU2sj2aVRxbnRpul8MoBm4/3RWiuPnuZNS281BTBUshJoOsPYrm4ABNBVjioY6QHVAFUcbSAPMl5ZntHPXiSyyejeeXzvanKcun1co5JF8uWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LaB2vwtz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LaB2vwtz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F1A1C433F1; Tue, 27 Feb 2024 14:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709043870; bh=urVwESKAPbYwzk9lRkDNB4g5/1VzRr+r/46DLK5795Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LaB2vwtz7s2p1aG2FvAIT90SofonDE2c5OUMVUKuCVI8VsYySU6/s2S/UxF/WzWzy 4pIcBpfqIIOLuJ/ySYESQgTCXvgqEjnMr+nfXEiPdU7SkvMVYmrUNe2LodDC3tQo3C P/xnkahAZiJeP4lfEjo1TlTL61jeWjkFodkfw4/I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kalesh AP , Selvin Xavier , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.4 64/84] RDMA/bnxt_re: Return error for SRQ resize Date: Tue, 27 Feb 2024 14:27:31 +0100 Message-ID: <20240227131554.954911532@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131552.864701583@linuxfoundation.org> References: <20240227131552.864701583@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kalesh AP [ Upstream commit 3687b450c5f32e80f179ce4b09e0454da1449eac ] SRQ resize is not supported in the driver. But driver is not returning error from bnxt_re_modify_srq() for SRQ resize. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier Link: https://lore.kernel.org/r/1705985677-15551-5-git-send-email-selvin.xavier@broadcom.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index 183f1c3c1f5ef..c9a7c03403ac0 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1623,7 +1623,7 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, switch (srq_attr_mask) { case IB_SRQ_MAX_WR: /* SRQ resize is not supported */ - break; + return -EINVAL; case IB_SRQ_LIMIT: /* Change the SRQ threshold */ if (srq_attr->srq_limit > srq->qplib_srq.max_wqe) @@ -1638,13 +1638,12 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, /* On success, update the shadow */ srq->srq_limit = srq_attr->srq_limit; /* No need to Build and send response back to udata */ - break; + return 0; default: dev_err(rdev_to_dev(rdev), "Unsupported srq_attr_mask 0x%x", srq_attr_mask); return -EINVAL; } - return 0; } int bnxt_re_query_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr) -- 2.43.0