From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53C9B13A26F; Tue, 27 Feb 2024 14:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043934; cv=none; b=WoqccDZoCOw9Mm61fF7FjW9KK9dp4KOsL6s8+A9tCGDi5OG68xTR5jO/dC5rukHU9cIGfI+czKsdMU7pohsnBohpqkLSOnLDchExXFRggMdsb/T13VXoKjLrwwJCDWJsk1w1Z9Q9EhZf8ghCHiiu9FQFG2XZ/MENLJ+hDqq74zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043934; c=relaxed/simple; bh=fvd4dO1FirHSIjovrx9PoQTZbQISd1O7EEcNqxP/BG8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u1m6qxc5APdDLIZbgt83bK0Jk/t1bAPO+CGmqiM+Z4/ft3Xd/kRrZsFOGgi8M37Qe+dUy/b0dNzc5MB2rWP6M0+U5/lZcM6fmdoLepenF9VNCkMkeDah9Aux87CRHnAAERkSe2h2DnWEut2O/tWHdD5ThVKYKP33awvFBpdA5Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BEFKe440; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BEFKe440" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5214C433C7; Tue, 27 Feb 2024 14:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709043934; bh=fvd4dO1FirHSIjovrx9PoQTZbQISd1O7EEcNqxP/BG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BEFKe440WZoHYJeV5uw1EqkXPpviqB0jgojyori2KUzSW9iCXL5osNvvjn4T+A0VB HbS+1vTQuX/H7SzIoMH2/ggSy46s0OXVYf6cVx7hRGS9lGVk7eZVwsc/xW0xl5t5Ze fTUnin+siUifFRzSZma9KdBYukIaRW9Rzn879nfA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wolfram Sang , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 75/84] packet: move from strlcpy with unused retval to strscpy Date: Tue, 27 Feb 2024 14:27:42 +0100 Message-ID: <20240227131555.310618901@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131552.864701583@linuxfoundation.org> References: <20240227131552.864701583@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit 8fc9d51ea2d32a05f7d7cf86a25cc86ecc57eb45 ] Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20220818210227.8611-1-wsa+renesas@sang-engineering.com Signed-off-by: Jakub Kicinski Stable-dep-of: a7d6027790ac ("arp: Prevent overflow in arp_req_get().") Signed-off-by: Sasha Levin --- net/packet/af_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 600a84a5c582a..451f9c43b34b8 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1850,7 +1850,7 @@ static int packet_rcv_spkt(struct sk_buff *skb, struct net_device *dev, */ spkt->spkt_family = dev->type; - strlcpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device)); + strscpy(spkt->spkt_device, dev->name, sizeof(spkt->spkt_device)); spkt->spkt_protocol = skb->protocol; /* @@ -3511,7 +3511,7 @@ static int packet_getname_spkt(struct socket *sock, struct sockaddr *uaddr, rcu_read_lock(); dev = dev_get_by_index_rcu(sock_net(sk), READ_ONCE(pkt_sk(sk)->ifindex)); if (dev) - strlcpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data)); + strscpy(uaddr->sa_data, dev->name, sizeof(uaddr->sa_data)); rcu_read_unlock(); return sizeof(*uaddr); -- 2.43.0