From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F5413DBBC; Tue, 27 Feb 2024 14:27:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709044031; cv=none; b=peq7Q0XI2BsmGtPvbDqjT9NTvZk8AK7LKVFuaF0o3mCdgbRoLB9YgD1d/TOlRbz0rQuGwSl4faCu/ySjpK8IINEQfqHObGtE0AuOHOFBhQ0yJUzuJNGIcPTwhPcdCLrU6R/JRTT3oAAXhw0CFkKEp7+MtNk541ukFybc5AJUAXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709044031; c=relaxed/simple; bh=GlNvMpbV3nSgOYn9cD043RxUB6frjAoya/mXRfIpeAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C0HOMy1iqtHoJDXSRc18BH3ChK9puegm5PkbxptL6c2pTYTYiMDcGZ9Salps1O7+NWzu+lR2S2he4W1rzxPA9klMu0+T5mLahW9SZLw1cvQYcIldy/cS6r+qbr9hvspf6ClojITGlaMoeyAg4k/zjN6AnxfPnLOdX7OTKy4PUP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JtOzEtVF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JtOzEtVF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C578DC433C7; Tue, 27 Feb 2024 14:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709044031; bh=GlNvMpbV3nSgOYn9cD043RxUB6frjAoya/mXRfIpeAM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JtOzEtVFIMIFigWlQYaaXQNCQ/xdG5X/cQUpgFqR0E9HJjS5kVR66hEtkS8HQFk1G /dzzM/H/g9yvjZDitMsVCRSvPQpwwJ/3Rs/WgXCs16RqCOXjmwUnYG0cqjQ4aY3k/a 1RxDG9oXm/jUV3oL6gE8Er8SLRLK7psYSi5EpiGQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Bresticker , Ard Biesheuvel , Sasha Levin Subject: [PATCH 5.10 036/122] efi: runtime: Fix potential overflow of soft-reserved region size Date: Tue, 27 Feb 2024 14:26:37 +0100 Message-ID: <20240227131559.887996435@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131558.694096204@linuxfoundation.org> References: <20240227131558.694096204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Bresticker [ Upstream commit de1034b38a346ef6be25fe8792f5d1e0684d5ff4 ] md_size will have been narrowed if we have >= 4GB worth of pages in a soft-reserved region. Signed-off-by: Andrew Bresticker Signed-off-by: Ard Biesheuvel Signed-off-by: Sasha Levin --- drivers/firmware/efi/arm-runtime.c | 2 +- drivers/firmware/efi/riscv-runtime.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 3359ae2adf24b..9054c2852580d 100644 --- a/drivers/firmware/efi/arm-runtime.c +++ b/drivers/firmware/efi/arm-runtime.c @@ -107,7 +107,7 @@ static int __init arm_enable_runtime_services(void) efi_memory_desc_t *md; for_each_efi_memory_desc(md) { - int md_size = md->num_pages << EFI_PAGE_SHIFT; + u64 md_size = md->num_pages << EFI_PAGE_SHIFT; struct resource *res; if (!(md->attribute & EFI_MEMORY_SP)) diff --git a/drivers/firmware/efi/riscv-runtime.c b/drivers/firmware/efi/riscv-runtime.c index d28e715d2bcc8..6711e64eb0b16 100644 --- a/drivers/firmware/efi/riscv-runtime.c +++ b/drivers/firmware/efi/riscv-runtime.c @@ -85,7 +85,7 @@ static int __init riscv_enable_runtime_services(void) efi_memory_desc_t *md; for_each_efi_memory_desc(md) { - int md_size = md->num_pages << EFI_PAGE_SHIFT; + u64 md_size = md->num_pages << EFI_PAGE_SHIFT; struct resource *res; if (!(md->attribute & EFI_MEMORY_SP)) -- 2.43.0