From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354A91420DC; Tue, 27 Feb 2024 14:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709044117; cv=none; b=cu9lrKklXsEWFyXN8c01HJVXW7v6EvLAOHKGwGRjr7Sjbixt5S3dC4Vi72RFGctpVzrdWqDAH2qaNFumlaHiGz11DUsnZ+kho7InShaJzj19/moYY6GpgKQS1hx+qGKei/cHFxQEoilq2OLPnjl+ToaYJc50E3JBwXbw0G8tOG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709044117; c=relaxed/simple; bh=UO4DAPSjHv4VK6ZcAOcTurMS0S/pp6MbHQUGtm3MmWs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tdx2AswUDFX6+F+Rg26CL1TK/sieORGS/i0Dvx7RKchlieJ4+Pn72B/VZzL3hpwZKN0c9c11TzUgvETe/jGyKc0qo1r5nF1r3uo188YHnDOqy/jjMOGLiwEp9LNKIZ8dcnX10g3vFj9lrPOPq6QPsTD0Z+rxzUGQmt5bDdaKKx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l6ScsPSg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l6ScsPSg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3250C433C7; Tue, 27 Feb 2024 14:28:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709044117; bh=UO4DAPSjHv4VK6ZcAOcTurMS0S/pp6MbHQUGtm3MmWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l6ScsPSgZXg1G0Uwcn6/pIgqe+Ejsspe/2W+MLGK8gNZOEmrMhB/+uNN/cpebVZju 0ZvOpktI1wgaGekTJqvNcrkW2llGsEy4vQNgyYFMGN8eTnadWAswAdJ5wcjuiyKTEk q3LpdjIXzBuD1WgK0p0iwD57qpSacTu2wbbvZbVU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yi Sun , Stefan Hajnoczi , Jens Axboe , Sasha Levin Subject: [PATCH 5.10 041/122] virtio-blk: Ensure no requests in virtqueues before deleting vqs. Date: Tue, 27 Feb 2024 14:26:42 +0100 Message-ID: <20240227131600.051968766@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131558.694096204@linuxfoundation.org> References: <20240227131558.694096204@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yi Sun [ Upstream commit 4ce6e2db00de8103a0687fb0f65fd17124a51aaa ] Ensure no remaining requests in virtqueues before resetting vdev and deleting virtqueues. Otherwise these requests will never be completed. It may cause the system to become unresponsive. Function blk_mq_quiesce_queue() can ensure that requests have become in_flight status, but it cannot guarantee that requests have been processed by the device. Virtqueues should never be deleted before all requests become complete status. Function blk_mq_freeze_queue() ensure that all requests in virtqueues become complete status. And no requests can enter in virtqueues. Signed-off-by: Yi Sun Reviewed-by: Stefan Hajnoczi Link: https://lore.kernel.org/r/20240129085250.1550594-1-yi.sun@unisoc.com Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/virtio_blk.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 9b54eec9b17eb..7eae3f3732336 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -952,14 +952,15 @@ static int virtblk_freeze(struct virtio_device *vdev) { struct virtio_blk *vblk = vdev->priv; + /* Ensure no requests in virtqueues before deleting vqs. */ + blk_mq_freeze_queue(vblk->disk->queue); + /* Ensure we don't receive any more interrupts */ vdev->config->reset(vdev); /* Make sure no work handler is accessing the device. */ flush_work(&vblk->config_work); - blk_mq_quiesce_queue(vblk->disk->queue); - vdev->config->del_vqs(vdev); kfree(vblk->vqs); @@ -977,7 +978,7 @@ static int virtblk_restore(struct virtio_device *vdev) virtio_device_ready(vdev); - blk_mq_unquiesce_queue(vblk->disk->queue); + blk_mq_unfreeze_queue(vblk->disk->queue); return 0; } #endif -- 2.43.0