From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4FB6145350; Tue, 27 Feb 2024 14:12:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043179; cv=none; b=AIgdYxTAQChLJqnD2wfn3pC6xs8Ir54XnUrtkfd5h/1qdhZhLmyryUDgHOGrmQ7BNrELDZ9iaeghQOaanGwbIZRdXPG9yUcIfGRDlVVMnfzoJ4fL+5Iq9SYUI5B0QBn3EQCEpA871Vut7Km2IOseiR4Y2FQlbXnX/zFJzGFmSgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709043179; c=relaxed/simple; bh=bGRrmA5MWwqaeR465HDLTADZ4jnZ4+3uw1SH0rhfFRw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AI50Ca2bWey4OKnPiVN1PgSXUvlSnEjaVokNXVCjmpResSGL6AA9B6BdbebUGwqsWZcqbCiRRnGZDLLFPIMb5kW5MOd1n9rLipyxn5r31ozHxDuD+PBtqDtd229qIYqguoavXCMToUGilgWk4y4op4CXmV777oMY7BSsKDCRM08= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=04RtqUE6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="04RtqUE6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 543D9C433C7; Tue, 27 Feb 2024 14:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709043179; bh=bGRrmA5MWwqaeR465HDLTADZ4jnZ4+3uw1SH0rhfFRw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=04RtqUE6KNa/kVnlJQPUR9IKQvPA+M0UkdFkKeztncLfdXxjQsiN79Cc0uYGCuxSE cf+sNVEla4jxU1gUWeFzeUMdmaH5xQLv4s8oQ0FS5KpIRfHkrc8DIIlKnkOtt8LhNi XtnNU6HLulOVAfPAzQlWCE9x4nszfiP9SBPvZKdk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Devyn Liu , Mark Brown , Sasha Levin Subject: [PATCH 6.1 017/195] spi: hisi-sfc-v3xx: Return IRQ_NONE if no interrupts were detected Date: Tue, 27 Feb 2024 14:24:38 +0100 Message-ID: <20240227131610.966359720@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131610.391465389@linuxfoundation.org> References: <20240227131610.391465389@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Devyn Liu [ Upstream commit de8b6e1c231a95abf95ad097b993d34b31458ec9 ] Return IRQ_NONE from the interrupt handler when no interrupt was detected. Because an empty interrupt will cause a null pointer error: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008 Call trace: complete+0x54/0x100 hisi_sfc_v3xx_isr+0x2c/0x40 [spi_hisi_sfc_v3xx] __handle_irq_event_percpu+0x64/0x1e0 handle_irq_event+0x7c/0x1cc Signed-off-by: Devyn Liu Link: https://msgid.link/r/20240123071149.917678-1-liudingyuan@huawei.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-hisi-sfc-v3xx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-hisi-sfc-v3xx.c b/drivers/spi/spi-hisi-sfc-v3xx.c index d3a23b1c2a4c5..61bf00dfe9c33 100644 --- a/drivers/spi/spi-hisi-sfc-v3xx.c +++ b/drivers/spi/spi-hisi-sfc-v3xx.c @@ -377,6 +377,11 @@ static const struct spi_controller_mem_ops hisi_sfc_v3xx_mem_ops = { static irqreturn_t hisi_sfc_v3xx_isr(int irq, void *data) { struct hisi_sfc_v3xx_host *host = data; + u32 reg; + + reg = readl(host->regbase + HISI_SFC_V3XX_INT_STAT); + if (!reg) + return IRQ_NONE; hisi_sfc_v3xx_disable_int(host); -- 2.43.0