From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA4613F01E; Tue, 27 Feb 2024 13:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709042016; cv=none; b=XCq0pdeJImP41qoodq8cU7Z+4J5QrNj59WdTE9eFtJdgZyY0reqeCnqEJZF31fWSh4sRTi8Oy+JWlv37T+/TMS56BmKzGFABZxSM/5pcz1wUW5KddBvRpbPu4Jp+74Tfkf+AmsDE4XjwNtjHnFbgWalMkOaoMAI7v1KjShmim9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709042016; c=relaxed/simple; bh=Av9CAseE8OyeOp77wxB26u1XvoZpTIQC67lvKSgGbpg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gkRUHzFvmP43LikPoZJ3elsLunizhytDgx7ScHRGbGIrq6ADNFS6cH1f2aUyEXSIU0GXOadCIesx+VSQzFBqLr1R5DPJDnF5Od58TZnUgB9oDcFGwMym+e6+OQP9YxAZfUENdVQHB6RgWF2IFceE0J+tb+f82deaKBqLmpjCBpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CVSwFi/4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CVSwFi/4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6559C433F1; Tue, 27 Feb 2024 13:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709042016; bh=Av9CAseE8OyeOp77wxB26u1XvoZpTIQC67lvKSgGbpg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CVSwFi/4Fn1tdpKEl1CPC44TDgXxPudjVmmoGmuY+OPgqcOS81KcIE3EmLimD6KjY spkTK9RYas17E0iBEvFbMW+QEpCYk57MeDLI2rtUN6UUXnAFcMV+zsUSSrldoDLACR SVKMN25D32pM6DyFPuN/yvTE+U1ljK93ycS4QKoY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Helge Deller , Guenter Roeck Subject: [PATCH 6.6 148/299] Revert "parisc: Only list existing CPUs in cpu_possible_mask" Date: Tue, 27 Feb 2024 14:24:19 +0100 Message-ID: <20240227131630.635343623@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227131625.847743063@linuxfoundation.org> References: <20240227131625.847743063@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Helge Deller commit 82b143aeb169b8b55798d7d2063032e1a6ceeeb0 upstream. This reverts commit 0921244f6f4f0d05698b953fe632a99b38907226. It broke CPU hotplugging because it modifies the __cpu_possible_mask after bootup, so that it will be different than nr_cpu_ids, which then effictively breaks the workqueue setup code and triggers crashes when shutting down CPUs at runtime. Guenter was the first who noticed the wrong values in __cpu_possible_mask, since the cpumask Kunit tests were failig. Reverting this commit fixes both issues, but sadly brings back this uncritical runtime warning: register_cpu_capacity_sysctl: too early to get CPU4 device! Signed-off-by: Helge Deller Reported-by: Guenter Roeck Link: https://lkml.org/lkml/2024/2/4/146 Link: https://lore.kernel.org/lkml/Zb0mbHlIud_bqftx@slm.duckdns.org/t/ Cc: stable@vger.kernel.org # 6.0+ Signed-off-by: Greg Kroah-Hartman --- arch/parisc/kernel/processor.c | 8 -------- 1 file changed, 8 deletions(-) --- a/arch/parisc/kernel/processor.c +++ b/arch/parisc/kernel/processor.c @@ -172,7 +172,6 @@ static int __init processor_probe(struct p->cpu_num = cpu_info.cpu_num; p->cpu_loc = cpu_info.cpu_loc; - set_cpu_possible(cpuid, true); store_cpu_topology(cpuid); #ifdef CONFIG_SMP @@ -474,13 +473,6 @@ static struct parisc_driver cpu_driver _ */ void __init processor_init(void) { - unsigned int cpu; - reset_cpu_topology(); - - /* reset possible mask. We will mark those which are possible. */ - for_each_possible_cpu(cpu) - set_cpu_possible(cpu, false); - register_parisc_driver(&cpu_driver); }