From: Greg KH <gregkh@linuxfoundation.org>
To: Chengming Zhou <chengming.zhou@linux.dev>
Cc: stable@vger.kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosryahmed@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled
Date: Tue, 27 Feb 2024 11:17:20 +0100 [thread overview]
Message-ID: <2024022714-reaffirm-spendable-4cb3@gregkh> (raw)
In-Reply-To: <95333296-d656-4982-bec0-aee2d54ba254@linux.dev>
On Tue, Feb 27, 2024 at 05:04:19PM +0800, Chengming Zhou wrote:
> On 2024/2/27 16:54, Greg KH wrote:
> > On Tue, Feb 27, 2024 at 02:26:54AM +0000, chengming.zhou@linux.dev wrote:
> >> From: Chengming Zhou <zhouchengming@bytedance.com>
> >>
> >> We have to invalidate any duplicate entry even when !zswap_enabled since
> >> zswap can be disabled anytime. If the folio store success before, then
> >> got dirtied again but zswap disabled, we won't invalidate the old
> >> duplicate entry in the zswap_store(). So later lru writeback may
> >> overwrite the new data in swapfile.
> >>
> >> Link: https://lkml.kernel.org/r/20240208023254.3873823-1-chengming.zhou@linux.dev
> >> Fixes: 42c06a0e8ebe ("mm: kill frontswap")
> >> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> >> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >> Cc: Nhat Pham <nphamcs@gmail.com>
> >> Cc: Yosry Ahmed <yosryahmed@google.com>
> >> Cc: <stable@vger.kernel.org>
> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >> (cherry picked from commit 678e54d4bb9a4822f8ae99690ac131c5d490cdb1)
> >
> > What tree is this for?
>
> Ah, for linux-6.7.y. I forgot to use your command line to send patch...
Thanks, both now queued up.
greg k-h
next prev parent reply other threads:[~2024-02-27 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:30 FAILED: patch "[PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled" failed to apply to 6.7-stable tree gregkh
2024-02-27 2:26 ` [PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled chengming.zhou
2024-02-27 8:54 ` Greg KH
2024-02-27 9:04 ` Chengming Zhou
2024-02-27 10:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-26 10:30 FAILED: patch "[PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled" failed to apply to 6.6-stable tree gregkh
2024-02-27 2:25 ` [PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled chengming.zhou
2024-02-27 8:54 ` Greg KH
2024-02-27 9:02 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024022714-reaffirm-spendable-4cb3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=nphamcs@gmail.com \
--cc=stable@vger.kernel.org \
--cc=yosryahmed@google.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox