From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6273A55E78 for ; Tue, 27 Feb 2024 08:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709024084; cv=none; b=iOWziqiC9+fhnyQikS6nSo+zGSY5ED1+unNBy+Vco77u/t/9R0N9DTbweo52Knk5ZeWSh8J6ymz3koV4T669cs1eBH1Iy2G6utGwqAA3SeMDBUFnt2Vp3vf3HSJ+FYzx4uaQweEPbyLYpiNdFep5GizBhkbQZ9vy0zPNaxZxJE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709024084; c=relaxed/simple; bh=T9SNTmEJJFyXiiwXdIhtEq1rOuxG3yNIBA4XTTkEvcA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JKkayp6cfYghfNRd1fPE5mMD+chJoZsYsOR+XLQT808EGprM/2qG6ii1wl5+ypxA0fvma2SUu8l3sbe4kZ0UVO/Y8fA4zZswHh4y2MB4YmOJ78mMr5S/+vp2opg5TdqswTVDbP1V7FtdK9uexy+YTe2jJpH5rMrRFRk534ViK60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=orqevyAo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="orqevyAo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84EFDC433C7; Tue, 27 Feb 2024 08:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709024083; bh=T9SNTmEJJFyXiiwXdIhtEq1rOuxG3yNIBA4XTTkEvcA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=orqevyAoX0wMsDM0Fg1SR3Ds97A8qJSUXoP7ZcgHZg4g5glU9ARg0CtSYjrrZOB/D pJmU7YRKqxVohenZJ4tiSMf9nGiIkRn0ILna4TdMMvjECqIibk3AuxpYl6bP1FrMYM y/wvtkBkLQg8agbndFK/33NvwNHc9Xw2nwnI/1lY= Date: Tue, 27 Feb 2024 09:54:41 +0100 From: Greg KH To: chengming.zhou@linux.dev Cc: stable@vger.kernel.org, Chengming Zhou , Johannes Weiner , Nhat Pham , Yosry Ahmed , Andrew Morton Subject: Re: [PATCH] mm/zswap: invalidate duplicate entry when !zswap_enabled Message-ID: <2024022728-phoenix-varsity-45e9@gregkh> References: <2024022622-resent-ripeness-43f1@gregkh> <20240227022540.3441860-1-chengming.zhou@linux.dev> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240227022540.3441860-1-chengming.zhou@linux.dev> On Tue, Feb 27, 2024 at 02:25:40AM +0000, chengming.zhou@linux.dev wrote: > From: Chengming Zhou > > We have to invalidate any duplicate entry even when !zswap_enabled since > zswap can be disabled anytime. If the folio store success before, then > got dirtied again but zswap disabled, we won't invalidate the old > duplicate entry in the zswap_store(). So later lru writeback may > overwrite the new data in swapfile. > > Link: https://lkml.kernel.org/r/20240208023254.3873823-1-chengming.zhou@linux.dev > Fixes: 42c06a0e8ebe ("mm: kill frontswap") > Signed-off-by: Chengming Zhou > Acked-by: Johannes Weiner > Cc: Nhat Pham > Cc: Yosry Ahmed > Cc: > Signed-off-by: Andrew Morton > (cherry picked from commit 678e54d4bb9a4822f8ae99690ac131c5d490cdb1) What tree is this for? thanks, greg k-h