6.6.19 won't compile with " [*] Compile the kernel with warnings as errors"

6.6.19 won't compile with " [*] Compile the kernel with warnings as errors"

[Rainer Fiebig]

The problem seems to be in fs/ntfs3/frecord.c.  Original messages were
in German, so here's my translation (original at the end of the post):

[...]
  CC      lib/zstd/common/zstd_common.o
  CC      arch/x86/kernel/cpu/feat_ctl.o
fs/ntfs3/frecord.c: In Funktion »ni_read_frame«:
fs/ntfs3/frecord.c:2460:16: Error: variable >>i_size<< is not used"
[-Werror=unused-variable]
 2460 |         loff_t i_size = i_size_read(&ni->vfs_inode);
      |                ^~~~~~
  AR      lib/zstd/built-in.a
[...]
cc1: All warnings are treated as errors
make[4]: *** [scripts/Makefile.build:243: fs/ntfs3/frecord.o] error 1
make[3]: *** [scripts/Makefile.build:480: fs/ntfs3] error 2
make[3]: *** Waiting for not yet finished processes....
[...]

Let me know if you need further information.  Thanks.

Rainer


--
Original messages:
[...]
  CC      lib/zstd/common/zstd_common.o
  CC      arch/x86/kernel/cpu/feat_ctl.o
fs/ntfs3/frecord.c: In Funktion »ni_read_frame«:
fs/ntfs3/frecord.c:2460:16: Fehler: Variable »i_size« wird nicht
verwendet [-Werror=unused-variable]
 2460 |         loff_t i_size = i_size_read(&ni->vfs_inode);
      |                ^~~~~~
  AR      lib/zstd/built-in.a
  CC      lib/bug.o
  CC      fs/udf/inode.o
  CC      arch/x86/kernel/cpu/intel.o
  CC      arch/x86/kernel/process_64.o
  CC      kernel/events/callchain.o
  CC      lib/buildid.o
cc1: Alle Warnungen werden als Fehler behandelt
make[4]: *** [scripts/Makefile.build:243: fs/ntfs3/frecord.o] Fehler 1
make[3]: *** [scripts/Makefile.build:480: fs/ntfs3] Fehler 2
make[3]: *** Es wird auf noch nicht beendete Prozesse gewartet....
  CC      kernel/events/hw_breakpoint.o
  CC      lib/clz_tab.o
  CC      lib/cmdline.o
  CC      fs/udf/lowlevel.o
[...]




-- 
The truth always turns out to be simpler than you thought.
Richard Feynman

Re: 6.6.19 won't compile with " [*] Compile the kernel with warnings as errors"

[Nathan Chancellor]

On Fri, Mar 01, 2024 at 03:42:17PM +0100, Rainer Fiebig wrote:
> fs/ntfs3/frecord.c: In Funktion »ni_read_frame«:
> fs/ntfs3/frecord.c:2460:16: Error: variable >>i_size<< is not used"
> [-Werror=unused-variable]
>  2460 |         loff_t i_size = i_size_read(&ni->vfs_inode);
>       |                ^~~~~~

This is a regression that was inherited from mainline because
commit 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write") was
applied to stable without commit c8e314624a16 ("fs/ntfs3: fix build
without CONFIG_NTFS3_LZX_XPRESS").

Cheers,
Nathan

Re: 6.6.19 won't compile with " [*] Compile the kernel with warnings as errors"

[Rainer Fiebig]

Am 01.03.24 um 18:56 schrieb Nathan Chancellor:
> On Fri, Mar 01, 2024 at 03:42:17PM +0100, Rainer Fiebig wrote:
>> fs/ntfs3/frecord.c: In Funktion »ni_read_frame«:
>> fs/ntfs3/frecord.c:2460:16: Error: variable >>i_size<< is not used"
>> [-Werror=unused-variable]
>>  2460 |         loff_t i_size = i_size_read(&ni->vfs_inode);
>>       |                ^~~~~~
> 
> This is a regression that was inherited from mainline because
> commit 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write") was
> applied to stable without commit c8e314624a16 ("fs/ntfs3: fix build
> without CONFIG_NTFS3_LZX_XPRESS").
With  CONFIG_NTFS3_LZX_XPRESS=y  the build was fine.
Thanks.

Rainer

> 
> Cheers,
> Nathan
> 

Re: 6.6.19 won't compile with " [*] Compile the kernel with warnings as errors"

[Greg Kroah-Hartman]

On Sat, Mar 02, 2024 at 10:30:54AM +0100, Rainer Fiebig wrote:
> Am 01.03.24 um 18:56 schrieb Nathan Chancellor:
> > On Fri, Mar 01, 2024 at 03:42:17PM +0100, Rainer Fiebig wrote:
> >> fs/ntfs3/frecord.c: In Funktion »ni_read_frame«:
> >> fs/ntfs3/frecord.c:2460:16: Error: variable >>i_size<< is not used"
> >> [-Werror=unused-variable]
> >>  2460 |         loff_t i_size = i_size_read(&ni->vfs_inode);
> >>       |                ^~~~~~
> > 
> > This is a regression that was inherited from mainline because
> > commit 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write") was
> > applied to stable without commit c8e314624a16 ("fs/ntfs3: fix build
> > without CONFIG_NTFS3_LZX_XPRESS").
> With  CONFIG_NTFS3_LZX_XPRESS=y  the build was fine.

Thanks for the report, will go do a new release with this fix in it.

greg k-h