From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDDFF200CD; Mon, 4 Mar 2024 21:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587554; cv=none; b=EmcHx6OhthGiRFUsGGZz45AGaglTE3rY60tEc944nKW+kHdxUWD2svQ9gIdWzIGbViI3VMpbmjFXZljXCUHoDL0fZKh9KRxW+CfT3BHRf8WKUBd8DD96uXCT7x/zZ4r7bYn4dGJ6OznTvVvjQoyQ8FN0Cm2fcGWKVJcXMkR0P1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709587554; c=relaxed/simple; bh=ihzJGj5/S7atUxAPXkAhFG1mdN366rJehWubnDPLBBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oepD6jrIqcAvgCXTQcT63SK3OnJAWnuKWR7neBnoA5VhK6IX3aqaCHorVcC5HYRLS2CXUfYdkhym2FEwRGuKzMHTgMwuuoz29BTaJzt+HQnF41WeiYs1gfwg9I+R11Kgp3tFg6NrDbridcY1iQMh3pakh+ELuOEI1iVHUD5f4s0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tZo5tyHs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tZo5tyHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57C63C433F1; Mon, 4 Mar 2024 21:25:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709587554; bh=ihzJGj5/S7atUxAPXkAhFG1mdN366rJehWubnDPLBBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tZo5tyHsbHD2pgZD8noTGm8MhwECCzj+jglO8peMw2749Ei8zvoAdSCYVDI5ByFEu CURq2B33QpOxJoYJPIsHGRn3eybU7SJWVFjgXTqBbt1Ce3X/evCVoMjLvreVMbM3u8 /zCGCZo1l3JtO8emCU8hl5mamR/ALbAXCK1tIBnU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Oleksij Rempel , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.19 03/16] lan78xx: enable auto speed configuration for LAN7850 if no EEPROM is detected Date: Mon, 4 Mar 2024 21:23:24 +0000 Message-ID: <20240304211534.452155989@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211534.328737119@linuxfoundation.org> References: <20240304211534.328737119@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Oleksij Rempel [ Upstream commit 0e67899abfbfdea0c3c0ed3fd263ffc601c5c157 ] Same as LAN7800, LAN7850 can be used without EEPROM. If EEPROM is not present or not flashed, LAN7850 will fail to sync the speed detected by the PHY with the MAC. In case link speed is 100Mbit, it will accidentally work, otherwise no data can be transferred. Better way would be to implement link_up callback, or set auto speed configuration unconditionally. But this changes would be more intrusive. So, for now, set it only if no EEPROM is found. Fixes: e69647a19c87 ("lan78xx: Set ASD in MAC_CR when EEE is enabled.") Signed-off-by: Oleksij Rempel Link: https://lore.kernel.org/r/20240222123839.2816561-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/lan78xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a44968d5cac48..c0fff40a98bb8 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2581,7 +2581,8 @@ static int lan78xx_reset(struct lan78xx_net *dev) if (dev->chipid == ID_REV_CHIP_ID_7801_) buf &= ~MAC_CR_GMII_EN_; - if (dev->chipid == ID_REV_CHIP_ID_7800_) { + if (dev->chipid == ID_REV_CHIP_ID_7800_ || + dev->chipid == ID_REV_CHIP_ID_7850_) { ret = lan78xx_read_raw_eeprom(dev, 0, 1, &sig); if (!ret && sig != EEPROM_INDICATOR) { /* Implies there is no external eeprom. Set mac speed */ -- 2.43.0