From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DF981C687; Mon, 4 Mar 2024 21:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588055; cv=none; b=RtIvb3gU33hP+OmVTdnhHJawhqe71zvAX4+5VHMxQ5046S6nfWIRDjE79ZJGolS2exzN2aYj/tL+A/2OtyZWBs398H4Pm0/fQs+5fEaMxnfmImypIbpUoSSVwg26GerR1qnYxGQjCoob8YZTWXoCPRHjcvZbqJjJZm+3Voqej7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588055; c=relaxed/simple; bh=toQsKhI024y18PjahEDRS+lKQXiN/dd+6M15UjoaM94=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WQkBTF/zFrdT8sG+ApUv419Lf0tdkBGgiFH5NzMWhYsUrWD1ded2Y4aDG9HS1neP4QfGlJTwGo8iK5XGu/fTjN7r73DYWFh1ZYTLcptMIldF2ff9UgpiZ7xs/xIupGVWm964wo1xxKvp0svKPB9NzIa0/jFCqtd+AcRXoOhYh9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=y+3xNkK2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="y+3xNkK2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5ED0C433F1; Mon, 4 Mar 2024 21:34:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709588055; bh=toQsKhI024y18PjahEDRS+lKQXiN/dd+6M15UjoaM94=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y+3xNkK2jr3ZZteU9SO+0+vDkagJrRvevOvWatVuGSBOVcFl+2ioxvPUbKZ87eO35 Bn/pn5QxjNflAMXNbH6dkeCgSP0exGmy5WzHh9LH4pwTWFdHIIQFe3IX0Fqfmnw0Y4 vpT1o5EZwtQP2YIcMZBHMVyGTfk2ERqcM6PWly2s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 5.4 08/25] Bluetooth: hci_event: Fix handling of HCI_EV_IO_CAPA_REQUEST Date: Mon, 4 Mar 2024 21:23:44 +0000 Message-ID: <20240304211536.025765216@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211535.741936181@linuxfoundation.org> References: <20240304211535.741936181@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Luiz Augusto von Dentz [ Upstream commit 7e74aa53a68bf60f6019bd5d9a9a1406ec4d4865 ] If we received HCI_EV_IO_CAPA_REQUEST while HCI_OP_READ_REMOTE_EXT_FEATURES is yet to be responded assume the remote does support SSP since otherwise this event shouldn't be generated. Link: https://lore.kernel.org/linux-bluetooth/CABBYNZ+9UdG1cMZVmdtN3U2aS16AKMCyTARZZyFX7xTEDWcMOw@mail.gmail.com/T/#t Fixes: c7f59461f5a7 ("Bluetooth: Fix a refcnt underflow problem for hci_conn") Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- net/bluetooth/hci_event.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index f5b46ea9d4c4d..6d1c7ec051a20 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -4469,9 +4469,12 @@ static void hci_io_capa_request_evt(struct hci_dev *hdev, struct sk_buff *skb) hci_dev_lock(hdev); conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &ev->bdaddr); - if (!conn || !hci_conn_ssp_enabled(conn)) + if (!conn || !hci_dev_test_flag(hdev, HCI_SSP_ENABLED)) goto unlock; + /* Assume remote supports SSP since it has triggered this event */ + set_bit(HCI_CONN_SSP_ENABLED, &conn->flags); + hci_conn_hold(conn); if (!hci_dev_test_flag(hdev, HCI_MGMT)) -- 2.43.0