From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD781C687; Mon, 4 Mar 2024 21:35:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588151; cv=none; b=JuoMxV2o57KaE3q3nKVAvHZyTZpGQ9kbLO7chzhww2+CWIBFFRz9zmHtuMPwoqksWZj5t39EKGt0yS2WGoxsXTAmnkNeLv6XLmu0YjliTLBhj47qxLrZ00tENmNDCTTk+9we+H08twwpaPi8hoMRa6ORE32D8LCmxf7GQc//Gfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588151; c=relaxed/simple; bh=1YUfYQPc4FQ5kXGbRz001GBmIlSHaUU1EcTmxypda28=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZMZNG6EPuMimfDzD5qpj9DyZFcdasoYGu/wPLtjIgmUKY3HyQKTUF/47aUmfy3pfyrywrvGBqa3uLinQEUAalsy+e+4JQIx/jM64F0p1lhjFFh1tz6Ai34wF8lmsZn9kXADHfyjs5hErKjvSj5VdfiqFPxDqYb/w3dyLkroDzSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0AhdDly9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0AhdDly9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C28DC433C7; Mon, 4 Mar 2024 21:35:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709588151; bh=1YUfYQPc4FQ5kXGbRz001GBmIlSHaUU1EcTmxypda28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0AhdDly9nRNIGIIbWdCFKcZo4yjICaRy6+V0kVPtNg2FlHuSB493DBZP1WkNx2uqd OvDqZCeCjkP/XicRNPNqlO0K7Kr7u04R9dKMKGWguShiaS7z83xiiYJbe6TYCA4Qdd RQ0wXw/zPGP3qYZ1GpQV4rRaeoTi2Kawdi0uRiLI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bartosz Golaszewski , Andy Shevchenko , Sasha Levin Subject: [PATCH 5.10 40/42] gpio: fix resource unwinding order in error path Date: Mon, 4 Mar 2024 21:24:07 +0000 Message-ID: <20240304211538.995122116@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211537.631764077@linuxfoundation.org> References: <20240304211537.631764077@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bartosz Golaszewski [ Upstream commit ec5c54a9d3c4f9c15e647b049fea401ee5258696 ] Hogs are added *after* ACPI so should be removed *before* in error path. Fixes: a411e81e61df ("gpiolib: add hogs support for machine code") Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/gpio/gpiolib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 9c3aa518e6b79..374bb9f432660 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -732,11 +732,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, ret = gpiochip_irqchip_init_valid_mask(gc); if (ret) - goto err_remove_acpi_chip; + goto err_free_hogs; ret = gpiochip_irqchip_init_hw(gc); if (ret) - goto err_remove_acpi_chip; + goto err_remove_irqchip_mask; ret = gpiochip_add_irqchip(gc, lock_key, request_key); if (ret) @@ -761,11 +761,11 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, gpiochip_irqchip_remove(gc); err_remove_irqchip_mask: gpiochip_irqchip_free_valid_mask(gc); -err_remove_acpi_chip: +err_free_hogs: + gpiochip_free_hogs(gc); acpi_gpiochip_remove(gc); gpiochip_remove_pin_ranges(gc); err_remove_of_chip: - gpiochip_free_hogs(gc); of_gpiochip_remove(gc); err_free_gpiochip_mask: gpiochip_free_valid_mask(gc); -- 2.43.0