From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE82BDDCB; Mon, 4 Mar 2024 21:36:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588209; cv=none; b=P0A68CgBpnT59C1XNosGxDmYmepPSGJa93W0w2w2/95ur3BHpi5pIfXCCFKb/tQ9vdKjsR0gWfgYbOc10fdnrOT/JHfsQytF4CypO7NkADjSWkGyKuoKpPwHUbRZtco7t4TQQ/EPEIk5LAEk4tUKyQFkDpSDc+zQEV7Ba5BPGm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588209; c=relaxed/simple; bh=tdAnAexnYa7HkeCCiN2KsS4DOnGqb6AEDpkO1Tpr68w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDZjNNsCkmbKWJZpOvgke3hmCyPq4W4ff3lYVlRrifZkG5l0xruubdKAidUnNmMvim9qrqAiddzj/Cpboz2ALkd6R0bc52ab2eRVB0g1BUct8d1nub9dLHW7gxejz4x+LVGioGGvzUAX+Vg1KfIA2P4q8MMBN4z8rU9pWwircQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AGiB5hbp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AGiB5hbp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76B66C433F1; Mon, 4 Mar 2024 21:36:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709588208; bh=tdAnAexnYa7HkeCCiN2KsS4DOnGqb6AEDpkO1Tpr68w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AGiB5hbp922twg0lS1W/Kv0YFivuQ8euNODmaX9Nh7oQ4o2qhYxGtKnkMb+RP+i8S GRntLwriDZbcdaPUuV0ZrlSjTSPfcQQl82E5PCoGylkxYo7jx6vmTSeP7/6i6rwh9p B19ESUyoKvuldCTUcChkHU7U0U4xDzYr+C0lnvYU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Charles Keepax , Linus Walleij , Mark Brown , Sasha Levin Subject: [PATCH 6.6 003/143] ASoC: cs35l34: Fix GPIO name and drop legacy include Date: Mon, 4 Mar 2024 21:22:03 +0000 Message-ID: <20240304211550.000162127@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211549.876981797@linuxfoundation.org> References: <20240304211549.876981797@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Walleij [ Upstream commit a6122b0b4211d132934ef99e7b737910e6d54d2f ] This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij Link: https://lore.kernel.org/r/20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index 6974dd4614103..04d9117b31ac7 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator; -- 2.43.0