From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F23947A5D; Mon, 4 Mar 2024 21:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588232; cv=none; b=m6bla3GP5ag5W185OhPeiQVpZmFHhgu2nEMbCQdx4Qq/6S/VT/WlwHH3r4unJQ9jHMkrp1lCCg015hdWp6XREaSy/hg3ZXlXTHz25/odQvzCr5ru025RpSBF4dISSQ69etATPIYwcemc3egiBDvg4iK59J+kEGew9CPOEwkR8K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588232; c=relaxed/simple; bh=oUgmHhm3RnwkEsNCWrkRPh3AQtj3TpnyZdsrYrVa3A0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WPmeu/v7hssQAHKGeAYPa3i5/IAm/d6OVIrck6hz7sVLeWD4UUsUFmv94W7+cCuXs/7vr3L+VoTnm0T7RDuNY43ydUbna5RZUewUX8Bpmhq2DgrKEWaePZQK39b2wo608rx7LN8hWweGQK8EQClQrylRL+NrA4DH0oTQJ7zG5xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=q5vUdGXo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="q5vUdGXo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D21ACC43394; Mon, 4 Mar 2024 21:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709588232; bh=oUgmHhm3RnwkEsNCWrkRPh3AQtj3TpnyZdsrYrVa3A0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q5vUdGXoPN/AFkD3pbIJBiruH9ucPabIDZZrlTPk1EGCKfAqmEKzOKKzdK/D5dK/1 YygKcmAyGz0hH1YuuBNosfNmpkO9hQPorUQAx01Af0JGUNm83o0tCw2faTn8opCilL 7K+DDsmyucQ3Ibn/29b8DED2MoBopTkmH+tCi8C8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zijun Hu , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 6.6 029/143] Bluetooth: qca: Fix wrong event type for patch config command Date: Mon, 4 Mar 2024 21:22:29 +0000 Message-ID: <20240304211550.872484864@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211549.876981797@linuxfoundation.org> References: <20240304211549.876981797@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zijun Hu [ Upstream commit c0dbc56077ae759f2dd602c7561480bc2b1b712c ] Vendor-specific command patch config has HCI_Command_Complete event as response, but qca_send_patch_config_cmd() wrongly expects vendor-specific event for the command, fixed by using right event type. Btmon log for the vendor-specific command are shown below: < HCI Command: Vendor (0x3f|0x0000) plen 5 28 01 00 00 00 > HCI Event: Command Complete (0x0e) plen 5 Vendor (0x3f|0x0000) ncmd 1 Status: Success (0x00) 28 Fixes: 4fac8a7ac80b ("Bluetooth: btqca: sequential validation") Signed-off-by: Zijun Hu Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btqca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 5a35ac4138c6c..0211f704a358b 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -152,7 +152,7 @@ static int qca_send_patch_config_cmd(struct hci_dev *hdev) bt_dev_dbg(hdev, "QCA Patch config"); skb = __hci_cmd_sync_ev(hdev, EDL_PATCH_CMD_OPCODE, sizeof(cmd), - cmd, HCI_EV_VENDOR, HCI_INIT_TIMEOUT); + cmd, 0, HCI_INIT_TIMEOUT); if (IS_ERR(skb)) { err = PTR_ERR(skb); bt_dev_err(hdev, "Sending QCA Patch config failed (%d)", err); -- 2.43.0