From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F081D8F58; Mon, 4 Mar 2024 21:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588343; cv=none; b=rQLaBfDdU95SyjQsn6709SKq9m3KzVR+SnudVOUSltf27652hYOSU7BQhipEj5IznMkObJV4g2SmACP81UwBtPfMcuiQtxvxcnItlta37WEwxx9HDebuTgpsXg9kBL08koBAHlaxWVVwcWf5EUlFxtTPQ/RLxrIs8u+uZYNnqlE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709588343; c=relaxed/simple; bh=ybvO1txTypEfD05b1Xge03s0ND8Scd/9Yk2rJedFbc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XVqdmFGU+7Y+Ci01ifCJu1a/6WG5HYaeVnwQxggqxMopVa5B2sOkwBmXQdzG5bZCfCef1niQzOWNyH/G4IPQcz0XXNq2lMPM7FUNhcH4GHS+vy/cz6sQlD5CDgftp24HAghvk5gaG9k5A2nB4Q/Vg7a1Ilbn/AzrJ3ur7IuVBqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vBSCogze; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vBSCogze" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82932C433F1; Mon, 4 Mar 2024 21:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709588342; bh=ybvO1txTypEfD05b1Xge03s0ND8Scd/9Yk2rJedFbc8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vBSCogzeH0pt1lCvAfA9gBg6YXiSAxxQYj5w3OpUEwED5ihS9OxuAZGmtBEHiuVLR /Zx2iA8oVtZhZZvYrUTgCfEmHDw8beUGkMpUxcFR+5DGQl4wYzSlaU4Xr9rQK4cCdD wgh+D9eUwwqBJQyCHrBmzKY8jfEESQJv88SseQGc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Takashi Iwai Subject: [PATCH 6.6 070/143] ALSA: ump: Fix the discard error code from snd_ump_legacy_open() Date: Mon, 4 Mar 2024 21:23:10 +0000 Message-ID: <20240304211552.159604141@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240304211549.876981797@linuxfoundation.org> References: <20240304211549.876981797@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai commit 49cbb7b7d36ec3ba73ce1daf7ae1d71d435453b8 upstream. snd_ump_legacy_open() didn't return the error code properly even if it couldn't open. Fix it. Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support") Cc: Link: https://lore.kernel.org/r/20240220150843.28630-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/core/ump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/core/ump.c +++ b/sound/core/ump.c @@ -985,7 +985,7 @@ static int snd_ump_legacy_open(struct sn struct snd_ump_endpoint *ump = substream->rmidi->private_data; int dir = substream->stream; int group = ump->legacy_mapping[substream->number]; - int err; + int err = 0; mutex_lock(&ump->open_mutex); if (ump->legacy_substreams[dir][group]) { @@ -1009,7 +1009,7 @@ static int snd_ump_legacy_open(struct sn spin_unlock_irq(&ump->legacy_locks[dir]); unlock: mutex_unlock(&ump->open_mutex); - return 0; + return err; } static int snd_ump_legacy_close(struct snd_rawmidi_substream *substream)