From: Greg KH <gregkh@linuxfoundation.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: stable@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
martineau@kernel.org
Subject: Re: FAILED: patch "[PATCH] mptcp: push at DSS boundaries" failed to apply to 5.4-stable tree
Date: Mon, 4 Mar 2024 10:21:49 +0100 [thread overview]
Message-ID: <2024030431-dragging-quack-7f57@gregkh> (raw)
In-Reply-To: <2cf7b693-af2f-42d5-b0a0-fba19e840fa6@kernel.org>
On Mon, Mar 04, 2024 at 10:00:01AM +0100, Matthieu Baerts wrote:
> Hi Greg,
>
> On 04/03/2024 09:28, gregkh@linuxfoundation.org wrote:
> > The patch below does not apply to the 5.4-stable tree.
>
> (...)
>
> > ------------------ original commit in Linus's tree ------------------
> >
> > From b9cd26f640a308ea314ad23532de9a8592cd09d2 Mon Sep 17 00:00:00 2001
> > From: Paolo Abeni <pabeni@redhat.com>
> > Date: Fri, 23 Feb 2024 17:14:14 +0100
> > Subject: [PATCH] mptcp: push at DSS boundaries
> >
> > when inserting not contiguous data in the subflow write queue,
> > the protocol creates a new skb and prevent the TCP stack from
> > merging it later with already queued skbs by setting the EOR marker.
> >
> > Still no push flag is explicitly set at the end of previous GSO
> > packet, making the aggregation on the receiver side sub-optimal -
> > and packetdrill self-tests less predictable.
> >
> > Explicitly mark the end of not contiguous DSS with the push flag.
> >
> > Fixes: 6d0060f600ad ("mptcp: Write MPTCP DSS headers to outgoing data packets")
>
> I guess this patch has been selected for v5.4 by accident because MPTCP
> has been introduced in v5.6. In other words, we don't need this patch
> for v5.4 :)
Oops, I read "5.6" as "5.4", my coffee hadn't kicked in yet, sorry.
greg k-h
prev parent reply other threads:[~2024-03-04 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 8:28 FAILED: patch "[PATCH] mptcp: push at DSS boundaries" failed to apply to 5.4-stable tree gregkh
2024-03-04 9:00 ` Matthieu Baerts
2024-03-04 9:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030431-dragging-quack-7f57@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox