From: Greg KH <gregkh@linuxfoundation.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: stable@vger.kernel.org, sashal@kernel.org,
MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [PATCH 6.1.y] mptcp: continue marking the first subflow as UNCONNECTED
Date: Mon, 4 Mar 2024 09:11:09 +0100 [thread overview]
Message-ID: <2024030459-value-disburse-1bc8@gregkh> (raw)
In-Reply-To: <20240228172121.243458-2-matttbe@kernel.org>
On Wed, Feb 28, 2024 at 06:21:21PM +0100, Matthieu Baerts (NGI0) wrote:
> After the 'Fixes' commit mentioned below, which is a partial backport,
> the MPTCP worker was no longer marking the first subflow as "UNCONNECTED"
> when the socket was transitioning to TCP_CLOSE state.
>
> As a result, in v6.1, it was no longer possible to reconnect to the just
> disconnected socket. Continue to do that like before, only for the first
> subflow.
>
> A few refactoring have been done around the 'msk->subflow' in later
> versions, and it looks like this is not needed to do that there, but
> still needed in v6.1. Without that, the 'disconnect' tests from the
> mptcp_connect.sh selftest fail: they repeat the transfer 3 times by
> reconnecting to the server each time.
>
> Fixes: 7857e35ef10e ("mptcp: get rid of msk->subflow")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> Notes:
> - This is specific to the 6.1 version having the partial backport.
All 6.1 backports now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-03-04 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 17:21 [PATCH 6.1.y] mptcp: continue marking the first subflow as UNCONNECTED Matthieu Baerts (NGI0)
2024-03-04 8:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024030459-value-disburse-1bc8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).