From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A15EA5D478; Mon, 11 Mar 2024 15:13:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710170003; cv=none; b=BazuytoCzeu69PXQFih9Q6WK+Sx/vtYBkpzQ5guDe2mbd2ZMeP0mc+zsdcMbrSyQUtF4afszwZrPlqX6Bbu4ouCwfpBQQS1TDIFEkyomzHV9cKxmUqd7U5K934J5oOEu9mKZYURtwaQl3A3FaasywRclx3yqViAvagqvNlqKl04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710170003; c=relaxed/simple; bh=S9i6rVDTLrc92ZdyKfg4Ixk7H6eGpB3PH6E05e+MPh0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WQHprln3CG9QEXi+Jh2UFZNA9Em8VT1C+bqnEGRkRCNrA1Ts4j5RmAOgQVIGcCBKdiqH/4o6X0rWySrTdVYHtwicG1e/zDAZk9OtUqBekOECyoRlTAQIZrqVqxxKeZ5U8XBdTmuV6sSU7OMZXcWRyQaxQAhMNn6LleE/d329iZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ppofodmH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ppofodmH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE355C433F1; Mon, 11 Mar 2024 15:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710170003; bh=S9i6rVDTLrc92ZdyKfg4Ixk7H6eGpB3PH6E05e+MPh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ppofodmHbVK1DKp9osxVgBljmkNyxz+AKN4+vOTN7dMG2oyzuQsAuLFGguTMEKrcl LYfjKrsRs4wyqrqdCIf0akKPISge4X3qPoYteQWwy6KhX+//Nu5Zo9sjUyv+VeOKYe xALK6Vcune5XheIwBS9O9GMYN0GsrbWJWyBgC1khmd0fy9MGsoFKnW7C1arBwoKxbV cd413iO+bb2Z1k88VGof0ZJxUcNuKhmBntislTHRgt/YG6g6sGvUZ/XV73d9SXBLTp i0jBgBFeXZjEbNtX8/G3NCXCqOP3z5XNkstbZp2c5QQ9xj0c8pl7ljPJ5IKgB5NbRy WHuL3FQfM9tkg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Felix Fietkau , Johannes Berg , Sasha Levin , johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 05/17] wifi: mac80211: only call drv_sta_rc_update for uploaded stations Date: Mon, 11 Mar 2024 11:12:56 -0400 Message-ID: <20240311151314.317776-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240311151314.317776-1-sashal@kernel.org> References: <20240311151314.317776-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.21 Content-Transfer-Encoding: 8bit From: Felix Fietkau [ Upstream commit 413dafc8170fcb925fb17af8842f06af305f8e0b ] When a station has not been uploaded yet, receiving SMPS or channel width notification action frames can lead to rate_control_rate_update calling drv_sta_rc_update with uninitialized driver private data. Fix this by adding a missing check for sta->uploaded. Signed-off-by: Felix Fietkau Link: https://msgid.link/20240221140535.16102-1-nbd@nbd.name Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/rate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index d5ea5f5bcf3a0..9d33fd2377c88 100644 --- a/net/mac80211/rate.c +++ b/net/mac80211/rate.c @@ -119,7 +119,8 @@ void rate_control_rate_update(struct ieee80211_local *local, rcu_read_unlock(); } - drv_sta_rc_update(local, sta->sdata, &sta->sta, changed); + if (sta->uploaded) + drv_sta_rc_update(local, sta->sdata, &sta->sta, changed); } int ieee80211_rate_control_register(const struct rate_control_ops *ops) -- 2.43.0