From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CEBE74404; Wed, 13 Mar 2024 17:02:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710349359; cv=none; b=otq+ZlxfCFZ7rEeqLtj/Pjn5pvnCIc/ClXDSET5XjTknxO/2ejVY5LcufcY0/KgEzIEQNtYzu3ACBuR7DAW+7y9HHuOvlIO7ZG7poPxdT4Fp9Zzd/WbHUDsCB4a87ULYSt0gq6Sdbn5xaFDu71/s7COY34mpGTDIMWjgZ5ZyKTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710349359; c=relaxed/simple; bh=SacSPlqczgIo91w9lgjs/R/yqzZTIMXubICyx2mgy2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qrV5wA8ez1oQkf/lXWPGxilySeaSHALQxGvT8oZrxIuLGdbWn3DOAkcZTxMYkXK0gPWZBKCSHufgnNWN07BVW1IycKN49aOjuBSYrUhZqvO9swrzFSrx/xee8zTKqa5vuJXW/pDzzb7Q3ku4hKahE5iojhEVBjUtT/YUg5RtOYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jRrWO7dJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jRrWO7dJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7882C43394; Wed, 13 Mar 2024 17:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710349359; bh=SacSPlqczgIo91w9lgjs/R/yqzZTIMXubICyx2mgy2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jRrWO7dJ394HFwYmZduC2jsrbmjqzrph4BDght1ZnD30hBrAGQUnoPA/8Ch4Fm/GL 0d/3ce8r4xT0dhM6HY2rC5H+NYkPSCvYI2RrjB+71shHcVhcHIJjHo3fdtJbOpV1Lr r9nMSG2n/tP2fhjy/NxIqKujFnemeschJvZDKmjPC9QQ1MEmRhS4+N7End46SY5pJE GAFrzzAavOmS9klxBl5qcVJdxeFz2B9mcjlTZIkIbKcsvxo9c3OFlbDovelL9ndKYr zT2JxEbSeiojSSjbCT909ynHklIe3MLlkGDxSgOezhwIeWFic3cGiizaeIzs2LjjI8 kAzKJWleYZ2wg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jason Xing , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 23/51] netrom: Fix a data-race around sysctl_netrom_link_fails_count Date: Wed, 13 Mar 2024 13:01:44 -0400 Message-ID: <20240313170212.616443-24-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240313170212.616443-1-sashal@kernel.org> References: <20240313170212.616443-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.272-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.272-rc1 X-KernelTest-Deadline: 2024-03-15T17:02+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jason Xing [ Upstream commit bc76645ebdd01be9b9994dac39685a3d0f6f7985 ] We need to protect the reader reading the sysctl value because the value can be changed concurrently. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jason Xing Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/netrom/nr_route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index 4fb5959a7f070..37cfa880c2d05 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -725,7 +725,7 @@ void nr_link_failed(ax25_cb *ax25, int reason) nr_neigh->ax25 = NULL; ax25_cb_put(ax25); - if (++nr_neigh->failed < sysctl_netrom_link_fails_count) { + if (++nr_neigh->failed < READ_ONCE(sysctl_netrom_link_fails_count)) { nr_neigh_put(nr_neigh); return; } -- 2.43.0