From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0FAF6D1C6; Wed, 13 Mar 2024 17:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710349344; cv=none; b=mMJ5MTK3/uKk6dAHuaKtBRIwrkFr2Yx+dFLKti9y1+domElTWTg+aA7fGofnT57Al7uha2Lk6TaqhqgigMFdlFKW0zhtAcoTS0FP49S9+lcOvdQji93h7BzGqCgO5+smN2QTf+FS2DYuZf1obZsImx9n7bG8hGXFFHXhvyacKAc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710349344; c=relaxed/simple; bh=pAviTd0UtyjF9JP5n1tHJ0A7tM2Ujl89aL2cNqhWO7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HdtPiSU9PIzEvvTlYG3wUmwGedPJz/KOu64k659hBLFvNuUgffjMyMIaEItc6f2MafhaLrMWsELs4pMWI9Bs09N3wxOXoEikF+1NOZKbNtil9XizvoZVJKhs1wfBsgWVeFjO0gp/7aIjtZjkpuwK8cYqS/RoJIveF70R3PSmHyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UG4Drw5V; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UG4Drw5V" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 710CEC433C7; Wed, 13 Mar 2024 17:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710349344; bh=pAviTd0UtyjF9JP5n1tHJ0A7tM2Ujl89aL2cNqhWO7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UG4Drw5VICw7VWCK7gzHQ0p07LZwe6LkzTGYxhonNLGDHO7Jfg93pieMmggvCa5HD uVGoGOY4/5k6WeoAMRKe+XQ0xH5FdGf1hrgqEKuGpBsvEUXa1ydqrpeOC4/9koIgaK ZCHZ8uPLVKTSO3Vr6uWjojDl+Xf52AXcPmVLuGemb0ftQaHrskNM2K3fNPVtXRUogR 7WZwFq6J7IxHKNPr25IRLdmYvuVsnK2YKJWOXHbzHBpWn7Eogtj18cs74zH2/zqIq+ kaWKFWxENLXQwL0aqHiGoO/VFazrKJRFGormSdJ/4D6um33ep/e7D1PSuUUyS9ACNa VAzU+biR4GrNw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Rand Deeb , Simon Horman , Tony Nguyen , Sasha Levin Subject: [PATCH 5.4 08/51] net: ice: Fix potential NULL pointer dereference in ice_bridge_setlink() Date: Wed, 13 Mar 2024 13:01:29 -0400 Message-ID: <20240313170212.616443-9-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240313170212.616443-1-sashal@kernel.org> References: <20240313170212.616443-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-KernelTest-Patch: http://kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.272-rc1.gz X-KernelTest-Tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git X-KernelTest-Branch: linux-5.4.y X-KernelTest-Patches: git://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git X-KernelTest-Version: 5.4.272-rc1 X-KernelTest-Deadline: 2024-03-15T17:02+00:00 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Rand Deeb [ Upstream commit 06e456a05d669ca30b224b8ed962421770c1496c ] The function ice_bridge_setlink() may encounter a NULL pointer dereference if nlmsg_find_attr() returns NULL and br_spec is dereferenced subsequently in nla_for_each_nested(). To address this issue, add a check to ensure that br_spec is not NULL before proceeding with the nested attribute iteration. Fixes: b1edc14a3fbf ("ice: Implement ice_bridge_getlink and ice_bridge_setlink") Signed-off-by: Rand Deeb Reviewed-by: Simon Horman Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ice/ice_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 209ae96875849..cf1baae963de2 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -4594,6 +4594,8 @@ ice_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh, pf_sw = pf->first_sw; /* find the attribute in the netlink message */ br_spec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), IFLA_AF_SPEC); + if (!br_spec) + return -EINVAL; nla_for_each_nested(attr, br_spec, rem) { __u16 mode; -- 2.43.0