* [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds
@ 2024-03-19 7:43 Kyle Tso
2024-03-19 13:58 ` Guenter Roeck
2024-03-22 9:47 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: Kyle Tso @ 2024-03-19 7:43 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh
Cc: badhri, linux-kernel, linux-usb, Kyle Tso, stable
The attribute writing should return the number of bytes used from the
buffer on success.
Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Cc: stable@vger.kernel.org
Signed-off-by: Kyle Tso <kyletso@google.com>
---
drivers/usb/typec/class.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index 389c7f0b8d93..9610e647a8d4 100644
--- a/drivers/usb/typec/class.c
+++ b/drivers/usb/typec/class.c
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
{
struct typec_port *port = to_typec_port(dev);
struct usb_power_delivery *pd;
+ int ret;
if (!port->ops || !port->ops->pd_set)
return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
if (!pd)
return -EINVAL;
- return port->ops->pd_set(port, pd);
+ ret = port->ops->pd_set(port, pd);
+ if (ret)
+ return ret;
+
+ return size;
}
static ssize_t select_usb_power_delivery_show(struct device *dev,
--
2.44.0.291.gc1ea87d7ee-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds
2024-03-19 7:43 [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds Kyle Tso
@ 2024-03-19 13:58 ` Guenter Roeck
2024-03-22 9:47 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2024-03-19 13:58 UTC (permalink / raw)
To: Kyle Tso, heikki.krogerus, gregkh; +Cc: badhri, linux-kernel, linux-usb, stable
On 3/19/24 00:43, Kyle Tso wrote:
> The attribute writing should return the number of bytes used from the
> buffer on success.
>
> Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/class.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 389c7f0b8d93..9610e647a8d4 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> {
> struct typec_port *port = to_typec_port(dev);
> struct usb_power_delivery *pd;
> + int ret;
>
> if (!port->ops || !port->ops->pd_set)
> return -EOPNOTSUPP;
> @@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> if (!pd)
> return -EINVAL;
>
> - return port->ops->pd_set(port, pd);
> + ret = port->ops->pd_set(port, pd);
> + if (ret)
> + return ret;
> +
> + return size;
> }
>
> static ssize_t select_usb_power_delivery_show(struct device *dev,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds
2024-03-19 7:43 [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds Kyle Tso
2024-03-19 13:58 ` Guenter Roeck
@ 2024-03-22 9:47 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2024-03-22 9:47 UTC (permalink / raw)
To: Kyle Tso; +Cc: linux, gregkh, badhri, linux-kernel, linux-usb, stable
On Tue, Mar 19, 2024 at 03:43:09PM +0800, Kyle Tso wrote:
> The attribute writing should return the number of bytes used from the
> buffer on success.
>
> Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kyle Tso <kyletso@google.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/class.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 389c7f0b8d93..9610e647a8d4 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> {
> struct typec_port *port = to_typec_port(dev);
> struct usb_power_delivery *pd;
> + int ret;
>
> if (!port->ops || !port->ops->pd_set)
> return -EOPNOTSUPP;
> @@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
> if (!pd)
> return -EINVAL;
>
> - return port->ops->pd_set(port, pd);
> + ret = port->ops->pd_set(port, pd);
> + if (ret)
> + return ret;
> +
> + return size;
> }
>
> static ssize_t select_usb_power_delivery_show(struct device *dev,
> --
> 2.44.0.291.gc1ea87d7ee-goog
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-22 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 7:43 [PATCH v1] usb: typec: Return size of buffer if pd_set operation succeeds Kyle Tso
2024-03-19 13:58 ` Guenter Roeck
2024-03-22 9:47 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox