Re: [PATCH 6.8 000/715] 6.8.2-rc1 review

Jon Hunter
2024-04-03T10:02:41Z

Hi Sasha,

On 24/03/2024 22:22, Sasha Levin wrote:
>
> This is the start of the stable review cycle for the 6.8.2 release.
> There are 715 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Mar 26 10:34:31 PM UTC 2024.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-6.8.y&id2=v6.8.1
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.8.y
> and the diffstat can be found below.
>
> Thanks,
> Sasha

...

> Tejun Heo (9):
> workqueue: Move pwq->max_active to wq->max_active
> workqueue: Factor out pwq_is_empty()
> workqueue: Replace pwq_activate_inactive_work() with
> [__]pwq_activate_work()
> workqueue: Move nr_active handling into helpers
> workqueue: Make wq_adjust_max_active() round-robin pwqs while
> activating
> workqueue: RCU protect wq->dfl_pwq and implement accessors for it
> workqueue: Introduce struct wq_node_nr_active
> workqueue: Implement system-wide nr_active enforcement for unbound
> workqueues
> workqueue: Don't call cpumask_test_cpu() with -1 CPU in
> wq_update_node_max_active()

Sorry I am late on this, but I was not copied and so did not see this. I
noticed a suspend regression on Tegra186 with v6.8.y and bisect is point
to commit "workqueue: Implement system-wide nr_active enforcement for
unbound workqueues".

Reverting commits "workqueue: Don't call cpumask_test_cpu() with -1 CPU
in wq_update_node_max_active()" and "workqueue: Implement system-wide
nr_active enforcement for unbound workqueues" does fix the problem.

Note that I am not seeing this regression on the mainline with v6.9-rc2
and so I am not sure if there is something else missing? I am also still
seeing the problem with v6.8.3-rc1.

Jon

--
nvpublic