From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4938F237B68; Sun, 24 Mar 2024 23:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322315; cv=none; b=GAuOKGiBVoa+YvyXe6PXvNNq4Pnm4AK6zXWxTh31SxXj5mtmoTJ2Fy7KYwjDUfEvNNlEF0kuCJjZfvoc+GVTAqQxT7lYI3dDh21Sp+y3v51x5TpNb4Umne8iLDewAXULqhRUoHP0QlmoHCbrIdtdAQn2JtfOv+ZYGwTkCdSPzhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322315; c=relaxed/simple; bh=gBhXWSoBYXejgNmTg9AjOpEs4SYyQFME6K8UyMn5e4U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VdSSinmXoCiWl6MX1PH2+CpZ4BHW+Nqmph8jU7oDwYAoB8pmYihz+gSAEWJReKwnwYWeTrm+0VwyTsahcO6U/OXyOYnZ6If+NM84QimHwnftIZtLvDRV5ID7xyb+Cp1k5SwgUFEhltYv/hQ6XJTT7W0ifeBwAm3kq/2nygO0O/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mDJNxWdj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mDJNxWdj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07CC1C433A6; Sun, 24 Mar 2024 23:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711322313; bh=gBhXWSoBYXejgNmTg9AjOpEs4SYyQFME6K8UyMn5e4U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mDJNxWdjX3KuhmuSdcr/aqaLOypChic2OICNcyWnU4VWI0QG9lFB5AZpTm61mnWrW nn67M+ihv4Wq53oHj97IoaHPG9v7POiT1avTxXdh+tbJZSkbLflfkc7cXZm7Tvugct zE88uGwg6lASEeaLylQ4ZFzznO6SPhmcJ0WVpweKP3AiqAOPv3HtZTyys1GeXoyOS9 9wMX+bH7aVco3w5SZtGpfwoNro7sQm0Cbk8D8/nNGTcf64VVbEBOpEaLIV/E4gR3YS ZZG4DZMYw1TTk4LWoWsSeWK9ZOHHFDn57Uik1YkFAah4erCGD/COO9xxqPxW6czrNS dyqWRZsk31zDA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin , AngeloGioacchino Del Regno , Sasha Levin Subject: [PATCH 6.1 396/451] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Sun, 24 Mar 2024 19:11:12 -0400 Message-ID: <20240324231207.1351418-397-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324231207.1351418-1-sashal@kernel.org> References: <20240324231207.1351418-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Randy Dunlap [ Upstream commit 544c42f798e1651dcb04fb0395219bf0f1c2607e ] IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Randy Dunlap Link: https://lore.kernel.org/r/20240213050258.6167-1-rdunlap@infradead.org Signed-off-by: Alexandre Belloni Signed-off-by: Sasha Levin --- drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index bb63edb507da4..87dc050ca004c 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1843,7 +1843,8 @@ config RTC_DRV_MT2712 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select -- 2.43.0