Re: [PATCH 5.15 000/317] 5.15.153-rc1 review

Harshit Mogalapalli
2024-03-25T05:52:43Z

Hi Sasha,

On 25/03/24 04:59, Sasha Levin wrote:
>
> This is the start of the stable review cycle for the 5.15.153 release.
> There are 317 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue Mar 26 11:34:43 PM UTC 2024.
> Anything received after that time might be too late.
>

We have a build failure in 5.15.153:
libbpf.c:74:12: error: 'map_set_def_max_entries' used but never defined
[-Werror]
74 | static int map_set_def_max_entries(struct bpf_map *map);
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

this function is not defined in 5.15.153

$ git grep "map_set_def_max_entries"
tools/lib/bpf/libbpf.c:static int map_set_def_max_entries(struct bpf_map
*map);
tools/lib/bpf/libbpf.c: err =
map_set_def_max_entries(map->inner_map);

This is introduced by PATCH: "[PATCH 5.15 067/317] libbpf: Apply
map_set_def_max_entries() for inner_maps on creation" in this series

This missing function is defined in commit: a4fbfdd7a160 ("libbpf: Fix
BPF_MAP_TYPE_PERF_EVENT_ARRAY auto-pinning") and pulling this in needs
some conflict resolution.

So I think for now the best idea is to drop this patch[067/317]

Thanks,
Harshit

> The whole patch series can be found in one patch at:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/patch/?id=linux-5.15.y&id2=v5.15.152
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> Thanks,
> Sasha
>