Re: [PATCH 5.15 110/317] arm64: dts: renesas: r8a779a0: Update to R-Car Gen4 compatible values

Geert Uytterhoeven
2024-04-02T08:57:56Z

Hi Sasha,

Looks like I missed some things in my previous review...

On Mon, Mar 25, 2024 at 12:36 AM Sasha Levin <sashal@kernel.org> wrote:
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> [ Upstream commit a1721bbbdb5c6687d157f8b8714bba837f6028ac ]

This is not the corresponding upstream commit for this commit
(a022251c2f950cd2 in v5.15.153).
It should be a1ca409cc050166a9e8ed183c1d4192f511cf6a2.
How could that happen? Interestingly, the backport in v6.1.83
(efab55e16c55c637) does have the correct upstream commit.

> Despite the name, R-Car V3U is the first member of the R-Car Gen4
> family. Hence update the compatible properties in various device nodes
> to include family-specific compatible values for R-Car Gen4 instead of
> R-Car Gen3:
> - DMAC,
> - (H)SCIF,
> - I2C,
> - IPMMU,
> - WDT.

Likewise, the description should be:

Despite the name, R-Car V3U is the first member of the R-Car Gen4
family. Hence update the compatible properties in various device nodes
to include family-specific compatible values for R-Car Gen4 instead of
R-Car Gen3:
- EtherAVB,
- MSIOF.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Likewise, bogus tag never given...

> Link: https://lore.kernel.org/r/73cea9d5e1a6639422c67e4df4285042e31c9fd5.1651497071.git.geert+renesas@glider.be

and a wrong link.

> Stable-dep-of: 0c51912331f8 ("arm64: dts: renesas: r8a779a0: Correct avb[01] reg sizes")
> Signed-off-by: Sasha Levin <sashal@kernel.org>

> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi

> @@ -935,7 +935,7 @@ scif4: serial@e6c40000 {
>
> msiof0: spi@e6e90000 {
> compatible = "renesas,msiof-r8a779a0",
> - "renesas,rcar-gen3-msiof";
> + "renesas,rcar-gen4-msiof";

The Renesas MSIOF driver in v5.15.153 does not handle
"renesas,rcar-gen4-msiof" yet. Please backport commit ea9d001550abaf2f
("spi: sh-msiof: add generic Gen4 binding") in v6.1 to fix that.

> reg = <0 0xe6e90000 0 0x0064>;
> interrupts = <GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 618>;

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds