From: Greg KH <gregkh@linuxfoundation.org>
To: Lee Jones <lee@kernel.org>
Cc: stable@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
valis <sec@valis.email>, Simon Horman <horms@kernel.org>,
Sabrina Dubroca <sd@queasysnail.net>,
"David S . Miller" <davem@davemloft.net>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1 1/1] tls: fix race between tx work scheduling and socket close
Date: Wed, 27 Mar 2024 15:35:43 +0100 [thread overview]
Message-ID: <2024032703-wager-mandatory-d732@gregkh> (raw)
In-Reply-To: <20240307155930.913525-1-lee@kernel.org>
On Thu, Mar 07, 2024 at 03:59:29PM +0000, Lee Jones wrote:
> From: Jakub Kicinski <kuba@kernel.org>
>
> [ Upstream commit e01e3934a1b2d122919f73bc6ddbe1cdafc4bbdb ]
>
> Similarly to previous commit, the submitting thread (recvmsg/sendmsg)
> may exit as soon as the async crypto handler calls complete().
> Reorder scheduling the work before calling complete().
> This seems more logical in the first place, as it's
> the inverse order of what the submitting thread will do.
>
> Reported-by: valis <sec@valis.email>
> Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> (cherry picked from commit 6db22d6c7a6dc914b12c0469b94eb639b6a8a146)
> [Lee: Fixed merge-conflict in Stable branches linux-6.1.y and older]
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> net/tls/tls_sw.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
Now qeueued up, but only this version, the older ones I've dropped from
my review queue based on the review from Jakub. If they are still
needed, can you provide backported versions?
thanks,
greg k-h
next prev parent reply other threads:[~2024-03-27 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 15:59 [PATCH 6.1 1/1] tls: fix race between tx work scheduling and socket close Lee Jones
2024-03-07 17:08 ` Jakub Kicinski
2024-03-07 17:09 ` Lee Jones
2024-03-07 17:14 ` Jakub Kicinski
2024-08-02 11:39 ` [PATCH 5.15.y] " Harshit Mogalapalli
2024-08-13 10:39 ` Greg Kroah-Hartman
2024-08-02 11:35 ` [PATCH 6.1 1/1] " Harshit Mogalapalli
2024-03-27 14:35 ` Greg KH [this message]
2024-03-27 14:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032703-wager-mandatory-d732@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=sashal@kernel.org \
--cc=sd@queasysnail.net \
--cc=sec@valis.email \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).