Re: [PATCH 6.1 1/1] tls: fix race between tx work scheduling and socket close

[Lee Jones <lee@kernel.org>]

On Wed, 27 Mar 2024, Greg KH wrote:

> On Thu, Mar 07, 2024 at 03:59:29PM +0000, Lee Jones wrote:
> > From: Jakub Kicinski <kuba@kernel.org>
> > 
> > [ Upstream commit e01e3934a1b2d122919f73bc6ddbe1cdafc4bbdb ]
> > 
> > Similarly to previous commit, the submitting thread (recvmsg/sendmsg)
> > may exit as soon as the async crypto handler calls complete().
> > Reorder scheduling the work before calling complete().
> > This seems more logical in the first place, as it's
> > the inverse order of what the submitting thread will do.
> > 
> > Reported-by: valis <sec@valis.email>
> > Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Reviewed-by: Simon Horman <horms@kernel.org>
> > Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > (cherry picked from commit 6db22d6c7a6dc914b12c0469b94eb639b6a8a146)
> > [Lee: Fixed merge-conflict in Stable branches linux-6.1.y and older]
> > Signed-off-by: Lee Jones <lee@kernel.org>
> > ---
> >  net/tls/tls_sw.c | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> > 
> 
> Now qeueued up, but only this version, the older ones I've dropped from
> my review queue based on the review from Jakub.  If they are still
> needed, can you provide backported versions?

Thanks.

Full disclosure, I have no plans to backport the remainder given Jakub's
comments.

-- 
Lee Jones [李琼斯]