From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Abdel Alkuor <abdelalkuor@geotab.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH RESEND 0/2] usb: typec: tipd: fix event checking in interrupt service routines
Date: Thu, 28 Mar 2024 17:44:29 +0100 [thread overview]
Message-ID: <2024032824-rasping-zone-7564@gregkh> (raw)
In-Reply-To: <20240328-tps6598x_fix_event_handling-v1-0-865842a30009@wolfvision.net>
On Thu, Mar 28, 2024 at 05:25:20PM +0100, Javier Carrasco wrote:
> The ISRs of the tps25750 and tps6598x do not handle generated events
> properly under all circumstances.
>
> The tps6598x ISR does not read all bits of the INT_EVENTX registers,
> leaving events signaled with bits above 64 unattended. Moreover, these
> events are not cleared, leaving the interrupt enabled.
>
> The tps25750 reads all bits of the INT_EVENT1 register, but the event
> checking is not right because the same event is checked in two different
> regions of the same register by means of an OR operation.
>
> This series aims to fix both issues by reading all bits of the
> INT_EVENTX registers, and limiting the event checking to the region
> where the supported events are defined (currently they are limited to
> the first 64 bits of the registers, as the are defined as BIT_ULL()).
>
> If the need for events above the first 64 bits of the INT_EVENTX
> registers arises, a different mechanism might be required. But for the
> current needs, all definitions can be left as they are.
>
> Note: resend to add 'stable' mailing list (fixes in the series).
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2024-03-28 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 16:25 [PATCH RESEND 0/2] usb: typec: tipd: fix event checking in interrupt service routines Javier Carrasco
2024-03-28 16:25 ` [PATCH RESEND 1/2] usb: typec: tipd: fix event checking for tps25750 Javier Carrasco
2024-03-28 16:28 ` kernel test robot
2024-03-28 16:25 ` [PATCH RESEND 2/2] usb: typec: tipd: fix event checking for tps6598x Javier Carrasco
2024-03-28 16:44 ` Greg Kroah-Hartman [this message]
2024-03-28 16:47 ` [PATCH RESEND 0/2] usb: typec: tipd: fix event checking in interrupt service routines Javier Carrasco
-- strict thread matches above, loose matches on Subject: below --
2024-03-28 16:55 Javier Carrasco
2024-04-02 10:21 ` Heikki Krogerus
2024-04-02 17:39 ` Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032824-rasping-zone-7564@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abdelalkuor@geotab.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco@wolfvision.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox