From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: stable@vger.kernel.org, Rickard x Andersson <rickaran@axis.com>,
stable <stable@kernel.org>
Subject: Re: [PATCH 6.1.y] tty: serial: imx: Fix broken RS485
Date: Fri, 29 Mar 2024 13:20:15 +0100 [thread overview]
Message-ID: <2024032908-phobia-umbrella-a2b4@gregkh> (raw)
In-Reply-To: <20240327185459.4717-1-cniedermaier@dh-electronics.com>
On Wed, Mar 27, 2024 at 07:54:59PM +0100, Christoph Niedermaier wrote:
> From: Rickard x Andersson <rickaran@axis.com>
>
> When about to transmit the function imx_uart_start_tx is called and in
> some RS485 configurations this function will call imx_uart_stop_rx. The
> problem is that imx_uart_stop_rx will enable loopback in order to
> release the RS485 bus, but when loopback is enabled transmitted data
> will just be looped to RX.
>
> This patch fixes the above problem by not enabling loopback when about
> to transmit.
>
> This driver now works well when used for RS485 half duplex master
> configurations.
>
> Fixes: 79d0224f6bf2 ("tty: serial: imx: Handle RS485 DE signal active high")
> Cc: stable <stable@kernel.org>
> Signed-off-by: Rickard x Andersson <rickaran@axis.com>
> Tested-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Link: https://lore.kernel.org/r/20240221115304.509811-1-rickaran@axis.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> (cherry picked from commit 672448ccf9b6a676f96f9352cbf91f4d35f4084a)
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> drivers/tty/serial/imx.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
Both now queued up, thanks!
greg k-h
prev parent reply other threads:[~2024-03-29 12:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 15:06 FAILED: patch "[PATCH] tty: serial: imx: Fix broken RS485" failed to apply to 6.1-stable tree gregkh
2024-03-27 18:54 ` [PATCH 6.1.y] tty: serial: imx: Fix broken RS485 Christoph Niedermaier
2024-03-29 12:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024032908-phobia-umbrella-a2b4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cniedermaier@dh-electronics.com \
--cc=rickaran@axis.com \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox