From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5F9B233A91; Fri, 29 Mar 2024 12:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716382; cv=none; b=ahk8LK/iPpYQmfzVCq6/6YnyO6QdkXJrWtTWHGe8B2GM9Wkwm93i6vV89NYkCeLuq492y8OjPUc3FnwTAw4hVgZBrq8xSZGAtgTYAxoFPkU2vID6HAi58eb7xOBtVh0ya4q6DFCAURuw6HLICANgGKmuMt/KRJKkVVe5EOGrPJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711716382; c=relaxed/simple; bh=kaa8ifzx6hH+2K+Lax/DSzP0zj6PNJSy9o/mAG2JK5Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NyOAxSDdeICXUCLHjB9gAsxHFNaeNs2ET8802/wbKMX3uTqclfto3nvwYSL7ZEGV1jarl9u4ZTGlVByrml1PTOn2SrObnVAP18zA+flGgDN+5yzXB6faLbnFRFdVZLztgZEbCtgCDVI9pDZgABfFy9SnmdCtNiacyRCmfu37Vt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M4sI7Sfg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M4sI7Sfg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB326C433C7; Fri, 29 Mar 2024 12:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711716381; bh=kaa8ifzx6hH+2K+Lax/DSzP0zj6PNJSy9o/mAG2JK5Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M4sI7Sfgm0sjA1UnKobFnPFXcBGsIQMdE9oLM2XoKZiCqM7P+KnzPitbGxLkmlFJP ScypDL5/ji23i19mlGLThX5Op43vPduFPKr1eNEgcnAxdckGxvBcQGJk4kUgo1bx0d ol1eTfuEPt+yo5eILe0Jb7DlOMtveQED50GMhZ0iIPPwaxDTcQXQUdvMZPNHG76HFL hMcq5Qowyd+DdaDgV70hz+KuZCskJ4lyyKvh3h/fFzIidt0qqwM4784MdcXqWB5kmS LjWgPwa/ewudz/gdPJFUFNttjCXhcVXpFUivbZ6rHyafRPHyH3DW+ozOMlijLALnY4 xmPmmvna7hYAg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Justin Tee , Himanshu Madhani , "Martin K . Petersen" , Sasha Levin , james.smart@broadcom.com, dick.kennedy@broadcom.com, jejb@linux.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 10/52] scsi: lpfc: Fix possible memory leak in lpfc_rcv_padisc() Date: Fri, 29 Mar 2024 08:45:04 -0400 Message-ID: <20240329124605.3091273-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240329124605.3091273-1-sashal@kernel.org> References: <20240329124605.3091273-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.83 Content-Transfer-Encoding: 8bit From: Justin Tee [ Upstream commit 2ae917d4bcab80ab304b774d492e2fcd6c52c06b ] The call to lpfc_sli4_resume_rpi() in lpfc_rcv_padisc() may return an unsuccessful status. In such cases, the elsiocb is not issued, the completion is not called, and thus the elsiocb resource is leaked. Check return value after calling lpfc_sli4_resume_rpi() and conditionally release the elsiocb resource. Signed-off-by: Justin Tee Link: https://lore.kernel.org/r/20240131185112.149731-3-justintee8345@gmail.com Reviewed-by: Himanshu Madhani Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_nportdisc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index b86ff9fcdf0c6..f21396a0ba9d0 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -748,8 +748,10 @@ lpfc_rcv_padisc(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, /* Save the ELS cmd */ elsiocb->drvrTimeout = cmd; - lpfc_sli4_resume_rpi(ndlp, - lpfc_mbx_cmpl_resume_rpi, elsiocb); + if (lpfc_sli4_resume_rpi(ndlp, + lpfc_mbx_cmpl_resume_rpi, + elsiocb)) + kfree(elsiocb); goto out; } } -- 2.43.0