Re: [PATCH] serial: 8250_dw: Revert: Do not reclock if already at correct rate

Linux regression tracking (Thorsten Leemhuis)
2024-04-05T06:14:09Z

On 29.03.24 13:12, Greg Kroah-Hartman wrote:
> On Fri, Mar 29, 2024 at 12:42:14PM +0100, Hans de Goede wrote:
>> On 3/29/24 3:35 AM, Peter Collingbourne wrote:
>>> On Thu, Mar 28, 2024 at 5:35 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>>> On 3/28/24 8:10 AM, Hans de Goede wrote:
>>>>> On 3/18/24 7:52 PM, Peter Collingbourne wrote:
>>>>>> On Mon, Mar 18, 2024 at 3:36 AM Andy Shevchenko
>>>>>> <andriy.shevchenko@linux.intel.com> wrote:
>>>>>>>
>>>>>>> On Sun, Mar 17, 2024 at 10:41:23PM +0100, Hans de Goede wrote:
>>>>>>>> Commit e5d6bd25f93d ("serial: 8250_dw: Do not reclock if already at
>>>>>>>> correct rate") breaks the dw UARTs on Intel Bay Trail (BYT) and
>>>>>>>> Cherry Trail (CHT) SoCs.
>>>>>>>>
>>>>>>>> Before this change the RTL8732BS Bluetooth HCI which is found
>>>>>>>> connected over the dw UART on both BYT and CHT boards works properly:
>>>>>>>>
>>>>>>>> Bluetooth: hci0: RTL: examining hci_ver=06 hci_rev=000b lmp_ver=06 lmp_subver=8723
>>>>>>>> Bluetooth: hci0: RTL: rom_version status=0 version=1
>>>>>>>> Bluetooth: hci0: RTL: loading rtl_bt/rtl8723bs_fw.bin
>>>>>>>> Bluetooth: hci0: RTL: loading rtl_bt/rtl8723bs_config-OBDA8723.bin
>>>>>>>> Bluetooth: hci0: RTL: cfg_sz 64, total sz 24508
>>>>>>>> Bluetooth: hci0: RTL: fw version 0x365d462e
>>>>>>>>
>>>>>>>> where as after this change probing it fails:
> [...]
>>> Acked-by: Peter Collingbourne <pcc@google.com>
>>
>> Thanks. Greg can we get this merged please
>> (it is a regression fix for a 6.8 regression) ?
>
> Will queue it up soon, thanks.

You are obviously busy (we really need to enhance Git so it can clone
humans, too!), nevertheless: friendly reminder that that fix afaics
still is not queued.

Side note: there is another fix for a serial 6.8 regression I track
waiting for review here:
https://lore.kernel.org/linux-serial/20240325071649.27040-1-tony@atomide.com/

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke