From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53EBA482DF; Mon, 1 Apr 2024 17:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711991297; cv=none; b=AILfsQoIkqi4wqhVkQILCUlcRd44GLacbFcmO5HqMj3vJefl2ExUigIqAlhjmhFErGr1sXWwUpgQsKCjidEizo/BCC+khB+pceXN+qxxQKniyw9XATFgiyxdPWkGxBug4Lbbm/2mdYT9X3gk4jholGN2ew4JJoZquJRkL3hYCm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711991297; c=relaxed/simple; bh=ZUVdOhBsdcdXuExfwd66/6dDnE/V/90E55HEpfNE6Ho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DvgsmUs5tnN+a9vO/PLOLtuBE3u3RQYQ+ccli4ZyF9y8fawlgCcq1/smtwy9svmNwgCpTz5Os28fPSC8HydyfUriVdGvThKD1dKznWvPl/IjY1XkuxlE8RIt0A1H1tZYaptNEusHI9yAYXbEu8JY6KxkLGQkSDwvwgWWvcrTHfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=C+bPLukZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="C+bPLukZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB3A3C43390; Mon, 1 Apr 2024 17:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711991297; bh=ZUVdOhBsdcdXuExfwd66/6dDnE/V/90E55HEpfNE6Ho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C+bPLukZkv2HCbjdrpOaNDSgn4jsKf3Jt7XPkM2TUrqaVe8nsMjuw19Kcnmz0+awR EptoVtb639S0irVi+Z3rnbTobKDFtZ4MILPatKmAP95CKm83yiTfCYtHNv0tfUR9Hk xH2HjgxDspMvsCANAIOTZRK/EIwCOH00JF5QvLYs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ye Zhang , Dhruva Gole , Lukasz Luba , "Rafael J. Wysocki" Subject: [PATCH 6.1 223/272] thermal: devfreq_cooling: Fix perf state when calculate dfc res_util Date: Mon, 1 Apr 2024 17:46:53 +0200 Message-ID: <20240401152537.909629931@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240401152530.237785232@linuxfoundation.org> References: <20240401152530.237785232@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ye Zhang commit a26de34b3c77ae3a969654d94be49e433c947e3b upstream. The issue occurs when the devfreq cooling device uses the EM power model and the get_real_power() callback is provided by the driver. The EM power table is sorted ascending，can't index the table by cooling device state，so convert cooling state to performance state by dfc->max_state - dfc->capped_state. Fixes: 615510fe13bd ("thermal: devfreq_cooling: remove old power model and use EM") Cc: 5.11+ # 5.11+ Signed-off-by: Ye Zhang Reviewed-by: Dhruva Gole Reviewed-by: Lukasz Luba Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -201,7 +201,7 @@ static int devfreq_cooling_get_requested res = dfc->power_ops->get_real_power(df, power, freq, voltage); if (!res) { - state = dfc->capped_state; + state = dfc->max_state - dfc->capped_state; /* Convert EM power into milli-Watts first */ dfc->res_util = dfc->em_pd->table[state].power;