From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3550247A57; Mon, 1 Apr 2024 16:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711988078; cv=none; b=fFiKyLPJC5Zyegmf+TivHSGX4j08pOi4/SG3cdwIUrSMOY0q2aV9VdTEkcaArNU9X30gUx0azApYTzR6UhenrlfUW4/9qUl8JlWTIgWJJ10oPyUrseyzw4ATizMb0sYey46qwlkf95SoqgezlyiKyeWZ40xbhS5QrSRhvLXDgoY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711988078; c=relaxed/simple; bh=WmOuV2YebVzEen/cdbFbXnva5lIspQ6pE8INtBFDe60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Gnd2aEWaOHXhb0dKH94qwFEd4nlEUFiXlx0MCrTrVR70tlUSvrdRRL1bVNhVYQEznCHned0pNHmpcekatrYkS6MTPO7sc37dYnK6f5QgTzPlGVq8+8VNqtW9V0vgSH/D0j2LGUK0L+2TKXtw4squVt5AOpJ8VOz3E9ejZBLNFCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lZHcCb+O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lZHcCb+O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86909C433F1; Mon, 1 Apr 2024 16:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711988078; bh=WmOuV2YebVzEen/cdbFbXnva5lIspQ6pE8INtBFDe60=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lZHcCb+O86ce4zoGe8nLF/YFMRKOuZXkLNBYBwMr2Xqx0+Q4MTm9n/Y0wnoC314pY MnzokBcgrMY0jlZo/QkgUIS62qDbBWVoEADmY2yJAu+HcTVVRwgDdvFkVinNtRbHDS z5Vkm+YftMsFV3C6zEaU8aXQ+weUwB+8u5fIX6+E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Randy Dunlap , Igor Zhbanov , "David S. Miller" , sparclinux@vger.kernel.org, Sam Ravnborg , Andrew Morton , Arnd Bergmann , Andreas Larsson , Sasha Levin Subject: [PATCH 6.7 038/432] sparc64: NMI watchdog: fix return value of __setup handler Date: Mon, 1 Apr 2024 17:40:25 +0200 Message-ID: <20240401152554.267774013@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240401152553.125349965@linuxfoundation.org> References: <20240401152553.125349965@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Randy Dunlap [ Upstream commit 3ed7c61e49d65dacb96db798c0ab6fcd55a1f20f ] __setup() handlers should return 1 to obsolete_checksetup() in init/main.c to indicate that the boot option has been handled. A return of 0 causes the boot option/value to be listed as an Unknown kernel parameter and added to init's (limited) argument or environment strings. Also, error return codes don't mean anything to obsolete_checksetup() -- only non-zero (usually 1) or zero. So return 1 from setup_nmi_watchdog(). Fixes: e5553a6d0442 ("sparc64: Implement NMI watchdog on capable cpus.") Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: "David S. Miller" Cc: sparclinux@vger.kernel.org Cc: Sam Ravnborg Cc: Andrew Morton Cc: stable@vger.kernel.org Cc: Arnd Bergmann Cc: Andreas Larsson Signed-off-by: Andreas Larsson Link: https://lore.kernel.org/r/20240211052802.22612-1-rdunlap@infradead.org Signed-off-by: Sasha Levin --- arch/sparc/kernel/nmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/nmi.c b/arch/sparc/kernel/nmi.c index 17cdfdbf1f3b7..149adc0947530 100644 --- a/arch/sparc/kernel/nmi.c +++ b/arch/sparc/kernel/nmi.c @@ -279,7 +279,7 @@ static int __init setup_nmi_watchdog(char *str) if (!strncmp(str, "panic", 5)) panic_on_timeout = 1; - return 0; + return 1; } __setup("nmi_watchdog=", setup_nmi_watchdog); -- 2.43.0