From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36293446AC; Mon, 1 Apr 2024 16:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711988030; cv=none; b=MLANw22SSFxto73F1/e5v4pdex9lZEnAhFaxSkLNP1XIOTbOMehlik0WF1vnotsOk/cECjWHIOKViE7iIHGNC0AOeYxGj1BlQJJbSPWNBB0y0QbD8Ar0cc6SP/MPkVoFDxWt43WNaD3+FKseZKqeMCZI9ZrXCO+IVNqeK/PgAog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711988030; c=relaxed/simple; bh=5J3pgt3avzoWrfBuOuCdaNrl6Dg1SSIycPElvGHC2Ks=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=udn0B8Nd8VOq+nXBfoSk1FYgOIWCuWnvBQhvvKShqFfCSgylKgOaVl4A7wRR+Ww+iZCWN9ZKYJ+P5SFagyY+g2jTHpcr+vj4u9C0RlrdL2U1+B6o7m8S8gboqZlYMIR1Nr7bkVK9+GGv2/kualNsKPlLoax7VA+4GuRTn2/tRE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HDAIAUDf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HDAIAUDf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9729AC433C7; Mon, 1 Apr 2024 16:13:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711988030; bh=5J3pgt3avzoWrfBuOuCdaNrl6Dg1SSIycPElvGHC2Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HDAIAUDfypY0MOOvbT3yGLaGf2Pb0U/YIs9JFh1IQ3+UxSmfiuEX6comHUlvHZmPj Gl1AjJ5O45Lgij+WNDRwN0B00iJedu70b2Sd3z5xn6QCotdy2dGxQzTFi+8anmNEcV LaTQI9MHj/UvpogVGxHqmH1N3y6QzzV2jIbAAb9I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Quentin Schulz , Heiko Stuebner , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 6.7 063/432] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2 Date: Mon, 1 Apr 2024 17:40:50 +0200 Message-ID: <20240401152555.005121689@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240401152553.125349965@linuxfoundation.org> References: <20240401152553.125349965@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.7-stable review patch. If anyone has any objections, please let me know. ------------------ From: Quentin Schulz [ Upstream commit b0a4546df24a4f8c59b2d05ae141bd70ceccc386 ] The SARADCv2 on RK3588 (the only SoC currently supported that has an SARADCv2) selects the channel through the channel_sel bitfield which is the 4 lowest bits, therefore the mask should be GENMASK(3, 0) and not GENMASK(15, 0). Fixes: 757953f8ec69 ("iio: adc: rockchip_saradc: Add support for RK3588") Signed-off-by: Quentin Schulz Reviewed-by: Heiko Stuebner Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/rockchip_saradc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c index dd94667a623bd..2da8d6f3241a1 100644 --- a/drivers/iio/adc/rockchip_saradc.c +++ b/drivers/iio/adc/rockchip_saradc.c @@ -52,7 +52,7 @@ #define SARADC2_START BIT(4) #define SARADC2_SINGLE_MODE BIT(5) -#define SARADC2_CONV_CHANNELS GENMASK(15, 0) +#define SARADC2_CONV_CHANNELS GENMASK(3, 0) struct rockchip_saradc; -- 2.43.0