From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7325B17BBB;
	Tue,  2 Apr 2024 05:40:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1712036447; cv=none; b=AFUK2GkSvM8uGUxz8VRXIz+mk0WLiIhfMLcsZs4I29rZF6vi9nQNDeqKq2QcjLZ+DkcJYA9dZS7Ycby5sHu6ZyoM4daNC92xqLjaCEwvVe748SugYTw+BeSiBQ6tDmfZtBSaTbCha65J++Qh7RrKnKzfzQ4wFVKtXzrxwQjTlAE=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1712036447; c=relaxed/simple;
	bh=+RXMODCJPF9BeRgEEKhCXn02zZG7tPP6TJksESLam+4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=XxWdnwg2YHyMEvlGcTEAOmuCREBcJXLM+OzwMji4MyLGb1qWoQ/+5/LBR3NonSIWdFT7PvEuRWuiXHYTZpOIywkB4WWtvvj8tviwNcC6CXXcuCEU3dCIA4Xx+4iNfyC7TDgKgeymBZP+9Ds+DHAPhsr4MXJNA81EFRrGOsnPMo8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2N0+7FN2; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2N0+7FN2"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85A8EC433C7;
	Tue,  2 Apr 2024 05:40:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1712036447;
	bh=+RXMODCJPF9BeRgEEKhCXn02zZG7tPP6TJksESLam+4=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=2N0+7FN2zo0VrrxakmLB0zetXw8EWIBVNXweXG4CSxXzfBlDHjqwXJdeH9YhKQ4xX
	 ooUV9NPioeHBJ0d4pEqC7bnriAghOOwIg2kXeP3gPz77RG9lPAFQLKaedRWdpNPHfj
	 8SUseO/buT6tshdHIAQfNft9r6pjVDt1cooVjaoE=
Date: Tue, 2 Apr 2024 07:40:43 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Christian A. Ehrhardt" <lk@c--e.de>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH 6.1 251/272] usb: typec: ucsi: Check for notifications
 after init
Message-ID: <2024040216-cahoots-gizzard-4ffb@gregkh>
References: <20240401152530.237785232@linuxfoundation.org>
 <20240401152538.859016197@linuxfoundation.org>
 <ZgsWLUHW8nqUv7pi@cae.in-ulm.de>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZgsWLUHW8nqUv7pi@cae.in-ulm.de>

On Mon, Apr 01, 2024 at 10:16:45PM +0200, Christian A. Ehrhardt wrote:
> 
> Hi Greg,
> 
> On Mon, Apr 01, 2024 at 05:47:21PM +0200, Greg Kroah-Hartman wrote:
> > 6.1-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Christian A. Ehrhardt <lk@c--e.de>
> > 
> > commit 808a8b9e0b87bbc72bcc1f7ddfe5d04746e7ce56 upstream.
> > 
> > The completion notification for the final SET_NOTIFICATION_ENABLE
> > command during initialization can include a connector change
> > notification.  However, at the time this completion notification is
> > processed, the ucsi struct is not ready to handle this notification.
> > As a result the notification is ignored and the controller
> > never sends an interrupt again.
> > 
> > Re-check CCI for a pending connector state change after
> > initialization is complete. Adjust the corresponding debug
> > message accordingly.
> > 
> > Fixes: 71a1fa0df2a3 ("usb: typec: ucsi: Store the notification mask")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
> > Link: https://lore.kernel.org/r/20240320073927.1641788-3-lk@c--e.de
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> >  drivers/usb/typec/ucsi/ucsi.c |   10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> This change has an out of bounds memory access. Please drop it from
> the stable trees until a fix is available.

Shouldn't we get a fix for Linus's tree too?  Have I missed that
somewhere?  Or should this just be reverted now?

thanks,

greg k-h