From: Greg KH <gregkh@linuxfoundation.org>
To: "Nguyen, Max" <hphyperxdev@gmail.com>
Cc: stable@vger.kernel.org, Chris Toledanes <chris.toledanes@hp.com>,
Carl Ng <carl.ng@hp.com>, Max Nguyen <maxwell.nguyen@hp.com>
Subject: Re: [PATCH 1/2] Add additional HyperX IDs to xpad.c on LTS v4.19 to v6.1
Date: Tue, 2 Apr 2024 07:45:08 +0200 [thread overview]
Message-ID: <2024040230-undivided-illusion-3930@gregkh> (raw)
In-Reply-To: <fb216446-26d5-4d73-a5f8-faf1ba689c3c@gmail.com>
On Mon, Apr 01, 2024 at 02:52:24PM -0700, Nguyen, Max wrote:
>
> On 3/17/2024 12:07 PM, Greg KH wrote:
> > On Fri, Mar 15, 2024 at 02:59:19PM -0700, Max Nguyen wrote:
> > > Add additional HyperX Ids to xpad_device and xpad_table
> > >
> > > Add to LTS versions 4.19, 5.4, 5.10, 5.15, 6.1
> > >
> > > Suggested-by: Chris Toledanes <chris.toledanes@hp.com>
> > > Reviewed-by: Carl Ng <carl.ng@hp.com>
> > > Signed-off-by: Max Nguyen <maxwell.nguyen@hp.com>
> > > ---
> > > drivers/input/joystick/xpad.c | 10 ++++++++--
> > > 1 file changed, 8 insertions(+), 2 deletions(-)
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read:
> > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> >
> > </formletter>
>
> Hi Greg,
> Thanks for your help so far. I am committed to figuring this out so thank you again your patience. I had a couple questions to confirm before I resubmit.
>
> I had done option 1 to include in stable when I submitted to mainline. I saw that my patch was picked up in the latest stable. Will it be eventually picked up by the older LTS versions?
Depends, did it apply to older LTS versions? If not, then no.
> I need to add the upstream commit ID to my patches. I intended to go with option 3 since there is some deviation in my patch from the upstream. Am I just missing the upstream commit ID and deviation explanation for my patch?
That is a start, yes. Try it and see!
thanks,
greg k-h
prev parent reply other threads:[~2024-04-02 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 21:59 [PATCH 1/2] Add additional HyperX IDs to xpad.c on LTS v4.19 to v6.1 Max Nguyen
2024-03-17 19:07 ` Greg KH
2024-04-01 21:52 ` Nguyen, Max
2024-04-02 5:45 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040230-undivided-illusion-3930@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=carl.ng@hp.com \
--cc=chris.toledanes@hp.com \
--cc=hphyperxdev@gmail.com \
--cc=maxwell.nguyen@hp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox