public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Mahmoud Adam <mngyadam@amazon.com>
To: <gregkh@linuxfoundation.org>
Cc: <djwong@kernel.org>, <stable@vger.kernel.org>
Subject: [PATCH 6.1 3/6] xfs: get root inode correctly at bulkstat
Date: Wed, 3 Apr 2024 14:59:51 +0200	[thread overview]
Message-ID: <20240403125949.33676-4-mngyadam@amazon.com> (raw)
In-Reply-To: <20240403125949.33676-1-mngyadam@amazon.com>

From: Hironori Shiina <shiina.hironori@gmail.com>

commit 817644fa4525258992f17fecf4f1d6cdd2e1b731 upstream.

The root inode number should be set to `breq->startino` for getting stat
information of the root when XFS_BULK_IREQ_SPECIAL_ROOT is used.
Otherwise, the inode search is started from 1
(XFS_BULK_IREQ_SPECIAL_ROOT) and the inode with the lowest number in a
filesystem is returned.

Fixes: bf3cb3944792 ("xfs: allow single bulkstat of special inodes")
Signed-off-by: Hironori Shiina <shiina.hironori@fujitsu.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Mahmoud Adam <mngyadam@amazon.com>
---
 fs/xfs/xfs_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 1f783e979629..85fbb3b71d1c 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -754,7 +754,7 @@ xfs_bulkstat_fmt(
 static int
 xfs_bulk_ireq_setup(
 	struct xfs_mount	*mp,
-	struct xfs_bulk_ireq	*hdr,
+	const struct xfs_bulk_ireq *hdr,
 	struct xfs_ibulk	*breq,
 	void __user		*ubuffer)
 {
@@ -780,7 +780,7 @@ xfs_bulk_ireq_setup(

 		switch (hdr->ino) {
 		case XFS_BULK_IREQ_SPECIAL_ROOT:
-			hdr->ino = mp->m_sb.sb_rootino;
+			breq->startino = mp->m_sb.sb_rootino;
 			break;
 		default:
 			return -EINVAL;
--
2.40.1

  parent reply	other threads:[~2024-04-03 13:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 12:59 [PATCH 6.1 0/6] backport xfs fix patches reported by xfs/179/270/557/606 Mahmoud Adam
2024-04-03 12:59 ` [PATCH 6.1 1/6] xfs: allow inode inactivation during a ro mount log recovery Mahmoud Adam
2024-04-03 12:59 ` [PATCH 6.1 2/6] xfs: fix log recovery when unknown rocompat bits are set Mahmoud Adam
2024-04-03 12:59 ` Mahmoud Adam [this message]
2024-04-03 12:59 ` [PATCH 6.1 4/6] xfs: short circuit xfs_growfs_data_private() if delta is zero Mahmoud Adam
2024-04-03 12:59 ` [PATCH 6.1 5/6] xfs: hoist refcount record merge predicates Mahmoud Adam
2024-04-03 12:59 ` [PATCH 6.1 6/6] xfs: estimate post-merge refcounts correctly Mahmoud Adam
2024-04-03 18:18 ` [PATCH 6.1 0/6] backport xfs fix patches reported by xfs/179/270/557/606 Darrick J. Wong
2024-04-04  5:45   ` Amir Goldstein
2024-04-04  9:15     ` Mahmoud Adam
2024-04-05  9:27       ` Greg KH
2024-04-05  9:55         ` Amir Goldstein
2024-04-11  7:22           ` Greg KH
2024-04-11 17:27             ` Leah Rumancik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403125949.33676-4-mngyadam@amazon.com \
    --to=mngyadam@amazon.com \
    --cc=djwong@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox