From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64C916D4CB; Wed, 3 Apr 2024 17:20:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164808; cv=none; b=cOISAaOGDYAhhqdifqBNN7HPIlsydygZcwXf6EY5LTw3OyPk6akrKF2aJ96k8HZyNYIMfwNtclFKuKyjl8OrfTFfHtigqxPoTZZiHLUZipvuu2vh7ZuoSkW/3SZrwKv8BPg3K6cNJTtvSu2PBrCfEDG4cwlnKy5eh0+74UkOBxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164808; c=relaxed/simple; bh=eH6n/XrrBzShozVSMmjhzduWadISNU3nrGIZ3CDYUjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=niKIXi1SmltMC5aCXbwHboFK2qd5kag1QGK4WudexoS/YmrcdDt4mON/mDu+7gs7Xecbkx4A1RBwRE7CsZog6RYyplT6/X4oKG7EZFUmSWbo7D9QVw4WsBOZC+ffHodJIChzzHVJgUkGaYfhNRaHJ9Hf2L8xIUgEkth3eBVejH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Meqnw+s4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Meqnw+s4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86976C433A6; Wed, 3 Apr 2024 17:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712164808; bh=eH6n/XrrBzShozVSMmjhzduWadISNU3nrGIZ3CDYUjo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Meqnw+s4HJH324rt71RaZJ5XtPjuYB1pIAEiM4oCwULM0asOgTl2sVuMZSHiyLs0S EtovsMxFw+FC3h5jNmtBf4icHPl70n8OT+LPi//ph6Bweer25Pf71rf0GCuxU1OwIk GlgPhcZC0rDVh6ijusnNpxF1LLux4g+2dNGVms4cnmGtb4lOS/irRczZ6NlF1Zb7wP NYHrm6oS+p+a9Ocm23Cs3mj7Ej8N07saujC5rU5PQJ/xmG+vCkR8vsKtcxruijRWya YgAg3fgupqBwcXvK3vUNtpeOkl8E3Uk8MuVEtdipVZk+7OxbmWFj3hcIRxMx7BcYt1 9FQ5dvDgj6utQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Karina Yankevich , Sergey Shtylyov , Alan Stern , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net Subject: [PATCH AUTOSEL 5.10 2/8] usb: storage: sddr55: fix sloppy typing in sddr55_{read|write}_data() Date: Wed, 3 Apr 2024 13:19:56 -0400 Message-ID: <20240403172006.353022-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240403172006.353022-1-sashal@kernel.org> References: <20240403172006.353022-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.214 Content-Transfer-Encoding: 8bit From: Karina Yankevich [ Upstream commit d6429a3555fb29f380c5841a12f5ac3f7444af03 ] In sddr55_{read|write}_data(), the address variables are needlessly typed as *unsigned long* -- which is 32-bit type on the 32-bit arches and 64-bit type on the 64-bit arches; those variables' value should fit into just 3 command bytes and consists of 10-bit block # (or at least the max block # seems to be 1023) and 4-/5-bit page # within a block, so 32-bit *unsigned* *int* type should be more than enough... Found by Linux Verification Center (linuxtesting.org) with the Svace static analysis tool. [Sergey: rewrote the patch subject/description] Signed-off-by: Karina Yankevich Signed-off-by: Sergey Shtylyov Reviewed-by: Alan Stern Link: https://lore.kernel.org/r/4c9485f2-0bfc-591b-bfe7-2059289b554e@omp.ru Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/sddr55.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c index 15dc25801cdcc..0aa079405d23c 100644 --- a/drivers/usb/storage/sddr55.c +++ b/drivers/usb/storage/sddr55.c @@ -196,7 +196,7 @@ static int sddr55_read_data(struct us_data *us, unsigned char *buffer; unsigned int pba; - unsigned long address; + unsigned int address; unsigned short pages; unsigned int len, offset; @@ -316,7 +316,7 @@ static int sddr55_write_data(struct us_data *us, unsigned int pba; unsigned int new_pba; - unsigned long address; + unsigned int address; unsigned short pages; int i; -- 2.43.0