public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Meetakshi Setiya <meetakshisetiyaoss@gmail.com>
Cc: stable@vger.kernel.org, Steve French <smfrench@gmail.com>,
	Shyam Prasad N <nspmangalore@gmail.com>,
	bharathsm@microsoft.com, Shyam Prasad N <sprasad@microsoft.com>,
	Meetakshi Setiya <msetiya@microsoft.com>
Subject: Re: Requesting backport for fc20c523211 (cifs: fixes for get_inode_info)
Date: Fri, 5 Apr 2024 08:34:52 +0200	[thread overview]
Message-ID: <2024040512-koala-landside-7486@gregkh> (raw)
In-Reply-To: <CAFTVevX=yujOXoDJYRJWuPgvWfVYUL5ZmoKfy_3u5qHi741Sag@mail.gmail.com>

On Wed, Apr 03, 2024 at 12:34:43PM +0530, Meetakshi Setiya wrote:
> commit fc20c523211a38b87fc850a959cb2149e4fd64b0 upstream
> cifs: fixes for get_inode_info
> requesting backport to 6.8.x, 6.6.x, 6.5.x and 6.1.x
> 
> This patch fixes memory leaks, adds error checking, and performs some important
> code modifications to the changes introduced by patch 2 of this patch series:
> https://lore.kernel.org/stable/CAFTVevX6=4qFo6nwV14sCnfPRO9yb9q+YsP3XPaHMsP08E05iQ@mail.gmail.com/
> commit ffceb7640cbfe6ea60e7769e107451d63a2fe3d3
> (smb: client: do not defer close open handles to deleted files)
> 
> This patch and the three patches in the mails that precede this are related and
> fix an important customer reported bug on the linux smb client (explained in the
> mail for patch 1). Patches 2, 3 and 4 are meant to fix whatever regressions were
> introduced/exposed by patch 1.
> The patches have to be applied in the mentioned order and should be backported
> together.

Then PLEASE send this as a patch series, as picking patches out of
emails that arrive in random order in a "correct" way is tough, if not
impossible for us to do.

Please send these as a backported set of patches, OR as a list of
"cherry-pick these git ids in this order" type of thing.  But spreading
it out over 4 emails just does not work, and is very very confusing.

Think about it, would you want to recieve these 4 emails and have to try
to guess which one is applied before which?

Please fix this up and resend it in an easier way.

thanks,

greg k-h

  reply	other threads:[~2024-04-05  6:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03  7:04 Requesting backport for fc20c523211 (cifs: fixes for get_inode_info) Meetakshi Setiya
2024-04-05  6:34 ` Greg KH [this message]
2024-04-10  5:51   ` Steve French
2024-04-10  5:58     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024040512-koala-landside-7486@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bharathsm@microsoft.com \
    --cc=meetakshisetiyaoss@gmail.com \
    --cc=msetiya@microsoft.com \
    --cc=nspmangalore@gmail.com \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox